[PR #1823] [MERGED] ROOT_URL setting use the default as shown in conf/app.ini #16066

New Issue

GiteaMirror · 2025-11-02T12:01:31-06:00

GiteaMirror commented

2025-11-02 12:01:31 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1823
Author: @MCF
Created: 5/27/2017
Status: ✅ Merged
Merged: 6/22/2017
Merged by: @lunny

Base: master ← Head: root_url_default

📝 Commits (1)

1513730 ROOT_URL setting use the default as shown in conf/app.ini

📊 Changes

1 file changed (+18 additions, -12 deletions)

View changed files

📝 modules/setting/setting.go (+18 -12)

📄 Description

The well commented conf/app.ini file that comes with the code shows the
ROOT_URL (i.e. setting.AppURL) as:

ROOT_URL = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/

However the installed custom/conf/app.ini file does not include this setting as
shown, and the default in the setting module was hard coded to
http://localhost:3000/ instead of what is shown above.

With this change the ROOT_URL will default to what is shown above if it is not
set in the custom/conf/app.ini.

Of course it is still possible to override the default by adding the ROOT_URL
setting to your custom/conf/app.ini file as usual.

Signed-off-by: Mike Fellows mike.fellows@shaw.ca

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1823 **Author:** [@MCF](https://github.com/MCF) **Created:** 5/27/2017 **Status:** ✅ Merged **Merged:** 6/22/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `root_url_default` --- ### 📝 Commits (1) - [`1513730`](https://github.com/go-gitea/gitea/commit/151373069d2aea16426c598d8f401f8799a41492) ROOT_URL setting use the default as shown in conf/app.ini ### 📊 Changes **1 file changed** (+18 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `modules/setting/setting.go` (+18 -12) </details> ### 📄 Description The well commented conf/app.ini file that comes with the code shows the ROOT_URL (i.e. setting.AppURL) as: ROOT_URL = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/ However the installed custom/conf/app.ini file does not include this setting as shown, and the default in the setting module was hard coded to http://localhost:3000/ instead of what is shown above. With this change the ROOT_URL will default to what is shown above if it is not set in the custom/conf/app.ini. Of course it is still possible to override the default by adding the ROOT_URL setting to your custom/conf/app.ini file as usual. Signed-off-by: Mike Fellows <mike.fellows@shaw.ca> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:01:31 -06:00

GiteaMirror closed this issue

2025-11-02 12:01:32 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16066