github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-01 07:03:57 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #1813] [MERGED] Fix deadlock in updateRepository #16061

New Issue
Closed
opened 2025-11-02 12:01:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:01:25 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1813
Author: @ethantkoenig
Created: 5/25/2017
Status: ✅ Merged
Merged: 5/26/2017
Merged by: @lunny

Base: master ← Head: fix_update_repo

📝 Commits (1)

  • d654c39 Fix deadlock in updateRepository

📊 Changes

1 file changed (+8 additions, -4 deletions)

View changed files

📝 models/repo.go (+8 -4)

📄 Description

Fix a potential deadlock in updateRepository(). The call to UpdateSize() previously did not use the provided session (i.e. the e parameter), and the resulting query could become blocked by the ongoing session/transaction, since both the query and the ongoing transaction need to access the repository table.

I experienced this deadlock locally, using PostgreSQL.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1813 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 5/25/2017 **Status:** ✅ Merged **Merged:** 5/26/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix_update_repo` --- ### 📝 Commits (1) - [`d654c39`](https://github.com/go-gitea/gitea/commit/d654c392b5c862d8df9570f23d50831c901a681c) Fix deadlock in updateRepository ### 📊 Changes **1 file changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `models/repo.go` (+8 -4) </details> ### 📄 Description Fix a potential deadlock in `updateRepository()`. The call to `UpdateSize()` previously did not use the provided session (i.e. the `e` parameter), and the resulting query could become blocked by the ongoing session/transaction, since both the query and the ongoing transaction need to access the `repository` table. I experienced this deadlock locally, using PostgreSQL. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:01:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16061