[PR #1783] [MERGED] Only run coverage on merges/pushes to master #16052

New Issue

GiteaMirror · 2025-11-02T12:01:12-06:00

GiteaMirror commented

2025-11-02 12:01:12 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1783
Author: @ethantkoenig
Created: 5/23/2017
Status: ✅ Merged
Merged: 5/24/2017
Merged by: @appleboy

Base: master ← Head: ci_build

📝 Commits (1)

5453e39 Only run coverage on merges/pushes to master

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 .drone.yml (+3 -1)
📝 Makefile (+4 -0)

📄 Description

Our CI builds are really slow (routinely over 40 minutes), and running the unit tests takes a large portion of the CI duration.

From running locally, it seems that running tests without coverage reports is much faster (~6x) than running with coverage reports (partly because they can be run in parallel, partly because shared code only needs to be compiled once). We don't really need coverage reports for commits/changes that aren't part of master, so only run a coverage report when changes are pushed/merged to master.

Changes the make test to only runs test (no coverage report), and adds the make test-coverage rule for generating a coverage report.

NOTE: needs signature for changes to drone.yml

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1783 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 5/23/2017 **Status:** ✅ Merged **Merged:** 5/24/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `ci_build` --- ### 📝 Commits (1) - [`5453e39`](https://github.com/go-gitea/gitea/commit/5453e39dafdc19ec1d01f72f19687d3e1c061560) Only run coverage on merges/pushes to master ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.drone.yml` (+3 -1) 📝 `Makefile` (+4 -0) </details> ### 📄 Description Our CI builds are really slow (routinely over 40 minutes), and running the unit tests takes a large portion of the CI duration. From running locally, it seems that running tests without coverage reports is much faster (~6x) than running with coverage reports (partly because they can be run in parallel, partly because shared code only needs to be compiled once). We don't really need coverage reports for commits/changes that aren't part of master, so only run a coverage report when changes are pushed/merged to master. Changes the `make test` to only runs test (no coverage report), and adds the `make test-coverage` rule for generating a coverage report. __NOTE__: needs signature for changes to `drone.yml` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:01:12 -06:00

GiteaMirror closed this issue

2025-11-02 12:01:13 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16052