[PR #1779] [MERGED] Fix activity feed #16050

New Issue

GiteaMirror · 2025-11-02T12:01:10-06:00

GiteaMirror commented

2025-11-02 12:01:10 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1779
Author: @ethantkoenig
Created: 5/23/2017
Status: ✅ Merged
Merged: 5/26/2017
Merged by: @lunny

Base: master ← Head: fix_action

📝 Commits (4)

dcebcb7 Fix activity feed
1014138 Add missing comment
2bee512 Fix migration, and remove fields completely
d7e3851 Tests

📊 Changes

11 files changed (+238 additions, -165 deletions)

View changed files

📝 integrations/mysql.ini (+12 -10)
📝 models/action.go (+83 -61)
📝 models/action_test.go (+44 -48)
📝 models/consistency.go (+0 -6)
📝 models/fixtures/action.yml (+0 -9)
📝 models/issue.go (+7 -8)
📝 models/issue_comment.go (+6 -7)
📝 models/migrations/migrations.go (+2 -0)
➕ models/migrations/v34.go (+44 -0)
📝 models/pull.go (+7 -8)
📝 routers/user/home.go (+33 -8)

📄 Description

Preserve actions after user/repo name change. Fixes #1730.

Essentially removes the act_user_name, repo_user_name, and repo_name columns from the action table (which can become stale when a user/repo changes name). There's really no point in having the act_user_name column, since you have the load the user for the avatar link anyways.

NOTE: I'm having some trouble getting the migration to work; if anyone knows how to drop columns with xorm, please help me out.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1779 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 5/23/2017 **Status:** ✅ Merged **Merged:** 5/26/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix_action` --- ### 📝 Commits (4) - [`dcebcb7`](https://github.com/go-gitea/gitea/commit/dcebcb78e9be89a3eb5b9dd486cfbbbe6aa870b8) Fix activity feed - [`1014138`](https://github.com/go-gitea/gitea/commit/1014138e08e0984ee58c45103dc1d3799d201694) Add missing comment - [`2bee512`](https://github.com/go-gitea/gitea/commit/2bee51241e111370e5e6d37c16deaf75b71f5e61) Fix migration, and remove fields completely - [`d7e3851`](https://github.com/go-gitea/gitea/commit/d7e3851cf1e6ef079c08bfaad23c5fdc93211a3e) Tests ### 📊 Changes **11 files changed** (+238 additions, -165 deletions) <details> <summary>View changed files</summary> 📝 `integrations/mysql.ini` (+12 -10) 📝 `models/action.go` (+83 -61) 📝 `models/action_test.go` (+44 -48) 📝 `models/consistency.go` (+0 -6) 📝 `models/fixtures/action.yml` (+0 -9) 📝 `models/issue.go` (+7 -8) 📝 `models/issue_comment.go` (+6 -7) 📝 `models/migrations/migrations.go` (+2 -0) ➕ `models/migrations/v34.go` (+44 -0) 📝 `models/pull.go` (+7 -8) 📝 `routers/user/home.go` (+33 -8) </details> ### 📄 Description Preserve actions after user/repo name change. Fixes #1730. Essentially removes the `act_user_name`, `repo_user_name`, and `repo_name` columns from the `action` table (which can become stale when a user/repo changes name). There's really no point in having the `act_user_name` column, since you have the load the user for the avatar link anyways. __NOTE__: I'm having some trouble getting the migration to work; if anyone knows how to drop columns with xorm, please help me out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:01:10 -06:00

GiteaMirror closed this issue

2025-11-02 12:01:10 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16050