[PR #1754] [MERGED] don't check minimum key size when disabled #16034

New Issue

GiteaMirror · 2025-11-02T12:00:47-06:00

GiteaMirror commented

2025-11-02 12:00:47 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1754
Author: @Gibheer
Created: 5/19/2017
Status: ✅ Merged
Merged: 10/26/2017
Merged by: @lunny

Base: master ← Head: master

📝 Commits (3)

9d52ac3 cleanup old comments for ed25519
ab376ba move the minimum key size config before the check
ab4034e Merge branch 'master' into master

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 models/ssh_key.go (+5 -5)

📄 Description

This fixes an issue that the key size was checked even when the config option was disabled. This led to errors on systems where ssh-keygen didn't report the key options in the expected format.

The other commit removes some older comments which are not correct anymore.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1754 **Author:** [@Gibheer](https://github.com/Gibheer) **Created:** 5/19/2017 **Status:** ✅ Merged **Merged:** 10/26/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`9d52ac3`](https://github.com/go-gitea/gitea/commit/9d52ac3c13cdf13107e1ba3bf75283b06a14e624) cleanup old comments for ed25519 - [`ab376ba`](https://github.com/go-gitea/gitea/commit/ab376ba9fb202b3c9189c57fa69476ae0f18216f) move the minimum key size config before the check - [`ab4034e`](https://github.com/go-gitea/gitea/commit/ab4034e14df774e11c2afb6672082858bd987356) Merge branch 'master' into master ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `models/ssh_key.go` (+5 -5) </details> ### 📄 Description This fixes an issue that the key size was checked even when the config option was disabled. This led to errors on systems where ssh-keygen didn't report the key options in the expected format. The other commit removes some older comments which are not correct anymore. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:00:47 -06:00

GiteaMirror closed this issue

2025-11-02 12:00:47 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16034