[PR #1648] [MERGED] Send mails as HTML as default. Setting for send as plain text. #15971

New Issue

GiteaMirror · 2025-11-02T11:59:16-06:00

GiteaMirror commented

2025-11-02 11:59:16 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1648
Author: @cez81
Created: 4/30/2017
Status: ✅ Merged
Merged: 6/7/2017
Merged by: @lunny

Base: master ← Head: html_email

📝 Commits (4)

7b1110f Send mails as HTML as default. Setting for send as plain text.
25989d2 Send only multipart or plain. Add deprication warning for ENABLE_HTML_ALTERNATIVE
12fd2da Still use ENABLE_HTML_ALTERNATIVE for backward compatibility
094bd67 Changed to not ignore html2text errors

📊 Changes

3 files changed (+29 additions, -23 deletions)

View changed files

📝 conf/app.ini (+2 -2)
📝 modules/mailer/mailer.go (+14 -13)
📝 modules/setting/setting.go (+13 -8)

📄 Description

As the default mail templates are all HTML and look rather crappy if sent as plain text I think the default should be to send as HTML. HTML is added as mime/alternative so it's still possible to view as plain text.

I have added a new setting, SEND_AS_PLAIN_TEXT, to send as plain text as default instead. Old setting, ENABLE_HTML_ALTERNATIVE, is removed.

Fixes https://github.com/go-gitea/gitea/issues/1342

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1648 **Author:** [@cez81](https://github.com/cez81) **Created:** 4/30/2017 **Status:** ✅ Merged **Merged:** 6/7/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `html_email` --- ### 📝 Commits (4) - [`7b1110f`](https://github.com/go-gitea/gitea/commit/7b1110f1f4650e632c8a5d02bb874596e5d53d29) Send mails as HTML as default. Setting for send as plain text. - [`25989d2`](https://github.com/go-gitea/gitea/commit/25989d214d2d2b3add0f7294b1830227dffdf3ca) Send only multipart or plain. Add deprication warning for ENABLE_HTML_ALTERNATIVE - [`12fd2da`](https://github.com/go-gitea/gitea/commit/12fd2dab48e82538dcfd3b6d88515472a77e0cb4) Still use ENABLE_HTML_ALTERNATIVE for backward compatibility - [`094bd67`](https://github.com/go-gitea/gitea/commit/094bd67c8cff4f154904d1d92a9d0fd6e94ab4e8) Changed to not ignore html2text errors ### 📊 Changes **3 files changed** (+29 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `conf/app.ini` (+2 -2) 📝 `modules/mailer/mailer.go` (+14 -13) 📝 `modules/setting/setting.go` (+13 -8) </details> ### 📄 Description As the default mail templates are all HTML and look rather crappy if sent as plain text I think the default should be to send as HTML. HTML is added as mime/alternative so it's still possible to view as plain text. I have added a new setting, SEND_AS_PLAIN_TEXT, to send as plain text as default instead. Old setting, ENABLE_HTML_ALTERNATIVE, is removed. Fixes https://github.com/go-gitea/gitea/issues/1342 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:59:17 -06:00

GiteaMirror closed this issue

2025-11-02 11:59:17 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15971