github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-15 20:52:52 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #1502] [MERGED] Do not allow commiting to protected branch from online editor #15930

New Issue
Closed
opened 2025-11-02 11:58:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:58:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1502
Author: @lafriks
Created: 4/16/2017
Status: ✅ Merged
Merged: 5/2/2017
Merged by: @lunny

Base: master ← Head: issue/1498

📝 Commits (2)

  • d82bad6 Do not allow commiting to protected branch from online editor
  • a9f1f7c Add editor integration tests for adding new file and not allowing to add new file to protected branch

📊 Changes

10 files changed (+386 additions, -15 deletions)

View changed files

📝 Makefile (+3 -3)
➕ integrations/editor_test.go (+106 -0)
➕ integrations/html_helper.go (+110 -0)
📝 integrations/integration_test.go (+81 -2)
📝 models/branches.go (+17 -0)
📝 models/fixtures/user.yml (+3 -2)
📝 modules/context/repo.go (+10 -0)
📝 options/locale/locale_en-US.ini (+1 -0)
📝 routers/repo/editor.go (+53 -6)
📝 templates/repo/editor/commit_form.tmpl (+2 -2)

📄 Description

Fix issue #1498

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1502 **Author:** [@lafriks](https://github.com/lafriks) **Created:** 4/16/2017 **Status:** ✅ Merged **Merged:** 5/2/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `issue/1498` --- ### 📝 Commits (2) - [`d82bad6`](https://github.com/go-gitea/gitea/commit/d82bad67baedfa864512de84c6a222baa2267dad) Do not allow commiting to protected branch from online editor - [`a9f1f7c`](https://github.com/go-gitea/gitea/commit/a9f1f7c2c6ff0ee8023d66df899e4df5bb1c02fd) Add editor integration tests for adding new file and not allowing to add new file to protected branch ### 📊 Changes **10 files changed** (+386 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+3 -3) ➕ `integrations/editor_test.go` (+106 -0) ➕ `integrations/html_helper.go` (+110 -0) 📝 `integrations/integration_test.go` (+81 -2) 📝 `models/branches.go` (+17 -0) 📝 `models/fixtures/user.yml` (+3 -2) 📝 `modules/context/repo.go` (+10 -0) 📝 `options/locale/locale_en-US.ini` (+1 -0) 📝 `routers/repo/editor.go` (+53 -6) 📝 `templates/repo/editor/commit_form.tmpl` (+2 -2) </details> ### 📄 Description Fix issue #1498 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:58:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15930
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?