github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #1470] [MERGED] Fix run command race #15919

New Issue
Closed
opened 2025-11-02 11:57:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:57:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1470
Author: @typeless
Created: 4/8/2017
Status: ✅ Merged
Merged: 11/13/2017
Merged by: @lunny

Base: master ← Head: fix-run-command-race

📝 Commits (5)

  • 77625c5 Use exec.CommandContext to simplfy timeout handling
  • cb66d5b Use sleep commmand instead of reading from stdin
  • 7dbf2d2 Make the error handling go-esque
  • 0f2a90c Merge branch 'master' into fix-run-command-race
  • 41a01f0 Merge branch 'master' into fix-run-command-race

📊 Changes

2 files changed (+33 additions, -22 deletions)

View changed files

📝 modules/process/manager.go (+8 -22)
📝 modules/process/manager_test.go (+25 -0)

📄 Description

Use exec.CommandContext to simplify timeout handling, and fixing the data races which can be identified by the added tests when -race enabled.

Related to #1453

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1470 **Author:** [@typeless](https://github.com/typeless) **Created:** 4/8/2017 **Status:** ✅ Merged **Merged:** 11/13/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix-run-command-race` --- ### 📝 Commits (5) - [`77625c5`](https://github.com/go-gitea/gitea/commit/77625c56011dad5d8a931842277e6943c7b419d3) Use exec.CommandContext to simplfy timeout handling - [`cb66d5b`](https://github.com/go-gitea/gitea/commit/cb66d5b2c35c0b8f189b9edde02866209b2a7db2) Use sleep commmand instead of reading from stdin - [`7dbf2d2`](https://github.com/go-gitea/gitea/commit/7dbf2d2120cb3c74bee9a3db37ce87f74a95670e) Make the error handling go-esque - [`0f2a90c`](https://github.com/go-gitea/gitea/commit/0f2a90cac74e116851b7e6d6edb9f3abb624241b) Merge branch 'master' into fix-run-command-race - [`41a01f0`](https://github.com/go-gitea/gitea/commit/41a01f0c0621a7c9ccd211a37a45f543f276837d) Merge branch 'master' into fix-run-command-race ### 📊 Changes **2 files changed** (+33 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `modules/process/manager.go` (+8 -22) 📝 `modules/process/manager_test.go` (+25 -0) </details> ### 📄 Description Use exec.CommandContext to simplify timeout handling, and fixing the data races which can be identified by the added tests when -race enabled. Related to #1453 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:57:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15919
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?