[PR #1456] [MERGED] Simple quick fix for #1418 #15912

New Issue

GiteaMirror · 2025-11-02T11:57:40-06:00

GiteaMirror commented

2025-11-02 11:57:40 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1456
Author: @sapk
Created: 4/6/2017
Status: ✅ Merged
Merged: 4/7/2017
Merged by: @appleboy

Base: master ← Head: fix-ui-1418-bug

📝 Commits (1)

6a2b670 Fix RPC failed: curl 56 Recv failed: Connection was aborted (#1418)

📊 Changes

5 files changed (+28 additions, -118 deletions)

View changed files

📝 public/css/index.css (+11 -59)
📝 public/less/_repository.less (+11 -53)
📝 templates/repo/settings/githooks.tmpl (+2 -2)
📝 templates/repo/settings/hook_history.tmpl (+2 -2)
📝 templates/repo/settings/hook_list.tmpl (+2 -2)

📄 Description

@Morlinest detected in #1418 a bug introduced in #1389.

This is mainly cause because I didn't catch impact on hooks pages and sub .menu item of .list

For .menu I use > parent link to fix sub .item catch.
And for hook remove specific code that interfere with global style.

This is a quick and "simple" fix and more work can be done to use less css hack and use class from semantic like .divided in place of :not(:first-child). This is done in #1450 and a progress is allready done in #1435 by @Morlinest

before

after

Hooks pages

before

hook history details

after

hook history details

For verification of no regression, I add screens of related pages of initial PR #1389.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1456 **Author:** [@sapk](https://github.com/sapk) **Created:** 4/6/2017 **Status:** ✅ Merged **Merged:** 4/7/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `fix-ui-1418-bug` --- ### 📝 Commits (1) - [`6a2b670`](https://github.com/go-gitea/gitea/commit/6a2b67041482b72ddca0b736ccdfb31ac86a332e) Fix #1418 ### 📊 Changes **5 files changed** (+28 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `public/css/index.css` (+11 -59) 📝 `public/less/_repository.less` (+11 -53) 📝 `templates/repo/settings/githooks.tmpl` (+2 -2) 📝 `templates/repo/settings/hook_history.tmpl` (+2 -2) 📝 `templates/repo/settings/hook_list.tmpl` (+2 -2) </details> ### 📄 Description @Morlinest detected in #1418 a bug introduced in #1389. This is mainly cause because I didn't catch impact on hooks pages and sub .menu item of .list For .menu I use > parent link to fix sub .item catch. And for hook remove specific code that interfere with global style. This is a quick and "simple" fix and more work can be done to use less css hack and use class from semantic like .divided in place of :not(:first-child). This is done in #1450 and a progress is allready done in #1435 by @Morlinest ### Menu **before** ![before-menu](https://cloud.githubusercontent.com/assets/4052400/24779572/96dee98e-1b31-11e7-80c4-e95df6bb0353.png) **after** ![after-menu](https://cloud.githubusercontent.com/assets/4052400/24779563/90c2d31c-1b31-11e7-8ae6-9b917dfe94aa.png) ### Hooks pages **before** ![before-githook](https://cloud.githubusercontent.com/assets/4052400/24779775/b347f164-1b32-11e7-8925-cd66b01734f4.png) ![before-webhook](https://cloud.githubusercontent.com/assets/4052400/24779778/b4b655f4-1b32-11e7-9eb3-4a4126621d6c.png) ![before-hook-history-1](https://cloud.githubusercontent.com/assets/4052400/24779592/b7be077a-1b31-11e7-9994-f48a0e8b9838.png) <details> <summary>hook history details</summary> ![before-hook-history-2](https://cloud.githubusercontent.com/assets/4052400/24779597/b9c2bb60-1b31-11e7-8c71-4e3e7b605090.png) ![before-hook-history-3](https://cloud.githubusercontent.com/assets/4052400/24779599/bb40d152-1b31-11e7-87ee-420932436ea9.png) </details> <br/> <br/> **after** ![after-githook](https://cloud.githubusercontent.com/assets/4052400/24779687/29b64a9a-1b32-11e7-9011-f2654f59c641.png) ![after-webhook](https://cloud.githubusercontent.com/assets/4052400/24779694/327715ce-1b32-11e7-9013-9c0f991f6cd5.png) ![after-hook-history-1](https://cloud.githubusercontent.com/assets/4052400/24779607/c7c5540c-1b31-11e7-888b-7350563ad0ee.png) <details> <summary>hook history details</summary> ![after-hook-history-2](https://cloud.githubusercontent.com/assets/4052400/24779609/c90163b0-1b31-11e7-9745-c9e15b0a8c7a.png) ![after-hook-history-3](https://cloud.githubusercontent.com/assets/4052400/24779613/ca7c79e6-1b31-11e7-9d1b-f6208baf7885.png) </details> <hr> <details> <summary>For verification of no regression, I add screens of related pages of initial PR #1389.</summary> ![settting-app](https://cloud.githubusercontent.com/assets/4052400/24779680/21cd8bfe-1b32-11e7-882a-6aedea697ba9.png) ![settting-ssh](https://cloud.githubusercontent.com/assets/4052400/24779682/21d15888-1b32-11e7-876c-c03b9ac8ee63.png) ![settting-email](https://cloud.githubusercontent.com/assets/4052400/24779679/21cd25b0-1b32-11e7-8095-182d492ba1f0.png) ![repo-deploy-key](https://cloud.githubusercontent.com/assets/4052400/24779681/21ce584a-1b32-11e7-9398-fed8ace838f4.png) </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:57:40 -06:00

GiteaMirror closed this issue

2025-11-02 11:57:40 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15912