github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 04:42:51 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #1420] [MERGED] Add length check for the return string #15898

New Issue
Closed
opened 2025-11-02 11:57:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:57:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1420
Author: @typeless
Created: 3/31/2017
Status: ✅ Merged
Merged: 3/31/2017
Merged by: @appleboy

Base: master ← Head: add-sanity-check

📝 Commits (3)

  • 9e81599 Add length check for the return string
  • 49d2f57 Differentiate error paths and logging messages
  • 7ae6fb5 Rectify error message

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 models/pull.go (+3 -1)

📄 Description

Without the check, it could lead to out-of-bound panic if the return string is shorter than expected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1420 **Author:** [@typeless](https://github.com/typeless) **Created:** 3/31/2017 **Status:** ✅ Merged **Merged:** 3/31/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `add-sanity-check` --- ### 📝 Commits (3) - [`9e81599`](https://github.com/go-gitea/gitea/commit/9e81599215c06f7c485137a84f262ed9bd3847f0) Add length check for the return string - [`49d2f57`](https://github.com/go-gitea/gitea/commit/49d2f572b6d488a5a923f2644e3fab5ee787b7ae) Differentiate error paths and logging messages - [`7ae6fb5`](https://github.com/go-gitea/gitea/commit/7ae6fb50ccb134c9f44cbbabf740ac78b3cc9b28) Rectify error message ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `models/pull.go` (+3 -1) </details> ### 📄 Description Without the check, it could lead to out-of-bound panic if the return string is shorter than expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:57:13 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15898
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?