[PR #1366] [MERGED] Include formatting check to the make test (and thus also check) rule #15880

New Issue

GiteaMirror · 2025-11-02T11:56:45-06:00

GiteaMirror commented

2025-11-02 11:56:45 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1366
Author: @strk
Created: 3/22/2017
Status: ✅ Merged
Merged: 6/6/2017
Merged by: @appleboy

Base: master ← Head: fmt-check

📝 Commits (4)

6fe0997 Forbid running "make fmt" with Go version != 1.7 or 1.8
c8d6f3a Include formatting check to the make check rule
a7649a1 Ignore bindata.go for spelling and formatting checks
5513ef0 Run make fmt

📊 Changes

3 files changed (+21 additions, -7 deletions)

View changed files

📝 Makefile (+18 -4)
📝 models/repo_test.go (+1 -1)
📝 modules/setting/setting.go (+2 -2)

📄 Description

... and give it its own standalone target too (make fmt-check)

\cc @lunny, @tboerger, @bkcsoft

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1366 **Author:** [@strk](https://github.com/strk) **Created:** 3/22/2017 **Status:** ✅ Merged **Merged:** 6/6/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `fmt-check` --- ### 📝 Commits (4) - [`6fe0997`](https://github.com/go-gitea/gitea/commit/6fe09977081be4940d177898552129c8b7175cea) Forbid running "make fmt" with Go version != 1.7 or 1.8 - [`c8d6f3a`](https://github.com/go-gitea/gitea/commit/c8d6f3a17519ded22fc3d709758947c158ce80d5) Include formatting check to the `make check` rule - [`a7649a1`](https://github.com/go-gitea/gitea/commit/a7649a1cf6e00bd1ded34393f9d6343fd37e18f4) Ignore bindata.go for spelling and formatting checks - [`5513ef0`](https://github.com/go-gitea/gitea/commit/5513ef0cf1d0c7acd244188845c1371efea27096) Run `make fmt` ### 📊 Changes **3 files changed** (+21 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+18 -4) 📝 `models/repo_test.go` (+1 -1) 📝 `modules/setting/setting.go` (+2 -2) </details> ### 📄 Description ... and give it its own standalone target too (make fmt-check) \cc @lunny, @tboerger, @bkcsoft --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:56:45 -06:00

GiteaMirror closed this issue

2025-11-02 11:56:45 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15880

[PR #1366] [MERGED] Include formatting check to the make test (and thus also check) rule #15880

📋 Pull Request Information

📝 Commits (4)

📊 Changes

📄 Description

[PR #1366] [MERGED] Include formatting check to the `make test` (and thus also `check`) rule #15880