[PR #1345] [MERGED] Remove href on first/last link when on first/last page #15872

Closed
opened 2025-11-02 11:56:34 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1345
Author: @aloupfor
Created: 3/20/2017
Status: Merged
Merged: 3/22/2017
Merged by: @lunny

Base: masterHead: remove-href-on-first-last-link-when-on-first-last-page


📝 Commits (1)

  • 9d7bfc0 Remove href on first/last link when on first/last page

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 templates/base/paginate.tmpl (+2 -2)

📄 Description

When you are on the first page of explore, the "First" link in pagination appears as disabled but it still has a href and so is clickable. Same thing for the "Last" link on the last page.
This PR aims to only have the href when the links are "enabled".


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1345 **Author:** [@aloupfor](https://github.com/aloupfor) **Created:** 3/20/2017 **Status:** ✅ Merged **Merged:** 3/22/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `remove-href-on-first-last-link-when-on-first-last-page` --- ### 📝 Commits (1) - [`9d7bfc0`](https://github.com/go-gitea/gitea/commit/9d7bfc0db7d9b62d60210d5f246042ede8f6de3c) Remove href on first/last link when on first/last page ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `templates/base/paginate.tmpl` (+2 -2) </details> ### 📄 Description When you are on the first page of explore, the "First" link in pagination appears as disabled but it still has a `href` and so is clickable. Same thing for the "Last" link on the last page. This PR aims to only have the `href` when the links are "enabled". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:56:34 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15872