[PR #1330] [MERGED] LFS: Return 404 for unimplemented endpoints #15865

New Issue

GiteaMirror · 2025-11-02T11:56:25-06:00

GiteaMirror commented

2025-11-02 11:56:25 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1330
Author: @fabian-z
Created: 3/19/2017
Status: ✅ Merged
Merged: 3/20/2017
Merged by: @lunny

Base: master ← Head: lock404

📝 Commits (1)

a005826 LFS: Return 404 for unimplemented endpoints

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 cmd/web.go (+3 -0)

📄 Description

Without this change a 401 is returned for unspecified endpoints, making the LFS client ask for HTTP credentials. This behaviour was introduced with the new locking API:

https://github.com/git-lfs/git-lfs/blob/master/docs/api/locking.md

git-lfs trace before and after patch:

trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload
trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify
trace git-lfs: HTTP: 401
trace git-lfs: setting repository access to basic

trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload
trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify
trace git-lfs: HTTP: 404
Remote "origin" does not support the LFS locking API. Consider disabling it with:
$ git config 'lfs.https://localhost/test/test.git/info/lfs.locksverify' false

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1330 **Author:** [@fabian-z](https://github.com/fabian-z) **Created:** 3/19/2017 **Status:** ✅ Merged **Merged:** 3/20/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `lock404` --- ### 📝 Commits (1) - [`a005826`](https://github.com/go-gitea/gitea/commit/a0058269d3c6ee92b2f9a0a5c4d6b430f1583062) LFS: Return 404 for unimplemented endpoints ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/web.go` (+3 -0) </details> ### 📄 Description Without this change a 401 is returned for unspecified endpoints, making the LFS client ask for HTTP credentials. This behaviour was introduced with the new locking API: https://github.com/git-lfs/git-lfs/blob/master/docs/api/locking.md git-lfs trace before and after patch: ``` trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify trace git-lfs: HTTP: 401 trace git-lfs: setting repository access to basic ``` ``` trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify trace git-lfs: HTTP: 404 Remote "origin" does not support the LFS locking API. Consider disabling it with: $ git config 'lfs.https://localhost/test/test.git/info/lfs.locksverify' false ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:56:25 -06:00

GiteaMirror closed this issue

2025-11-02 11:56:25 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15865