[PR #1150] [MERGED] GPG commit validation #15788

Closed
opened 2025-11-02 11:54:35 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1150
Author: @sapk
Created: 3/9/2017
Status: Merged
Merged: 3/22/2017
Merged by: @lunny

Base: masterHead: gpg-commit-validation


📝 Commits (4)

  • 3afb5b0 GPG commit validation
  • ff77237 Add translation
  • 4ced54d Move hash calc after retrieving of potential key + missing translation
  • 1721cf4 Add some little test

📊 Changes

14 files changed (+480 additions, -21 deletions)

View changed files

📝 models/gpg_key.go (+186 -0)
📝 models/gpg_key_test.go (+116 -0)
📝 options/locale/locale_en-US.ini (+10 -0)
📝 public/css/index.css (+33 -2)
📝 public/less/_repository.less (+37 -2)
📝 routers/api/v1/convert/convert.go (+7 -0)
📝 routers/repo/commit.go (+5 -0)
📝 templates/repo/commits_table.tmpl (+16 -3)
📝 templates/repo/diff/page.tmpl (+17 -2)
📝 vendor/code.gitea.io/git/commit.go (+20 -0)
📝 vendor/code.gitea.io/git/repo_commit.go (+6 -0)
📝 vendor/code.gitea.io/sdk/gitea/hook.go (+15 -6)
📝 vendor/code.gitea.io/sdk/gitea/user_gpgkey.go (+6 -0)
📝 vendor/vendor.json (+6 -6)

📄 Description

Display signed commit and validation against gpg key in database. I have started with a very little UI with the a simple title attr indicating the reason.

Examples:
capture d ecran_2017-03-12_23-29-23

For comparison : https://github.com/sapk/testing-git/commits/master

Need and follow : #710 go-gitea/git#36

TODO List :

  • UI of commits list
  • UI of commit page
  • UI file history (same as commits list)
  • UI search commit (same as commits list)
  • UI diff commit list (same as commits list)
  • Add support for translation of new strings

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1150 **Author:** [@sapk](https://github.com/sapk) **Created:** 3/9/2017 **Status:** ✅ Merged **Merged:** 3/22/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `gpg-commit-validation` --- ### 📝 Commits (4) - [`3afb5b0`](https://github.com/go-gitea/gitea/commit/3afb5b02a880775fe83f25262f65bea92da601fc) GPG commit validation - [`ff77237`](https://github.com/go-gitea/gitea/commit/ff77237b64e3208a71447db18bb728529e88c6e5) Add translation - [`4ced54d`](https://github.com/go-gitea/gitea/commit/4ced54d1b0935cd95436d2dad7f2f5b609d1f957) Move hash calc after retrieving of potential key + missing translation - [`1721cf4`](https://github.com/go-gitea/gitea/commit/1721cf474e23675be714cc59593b74cb2a6c1682) Add some little test ### 📊 Changes **14 files changed** (+480 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `models/gpg_key.go` (+186 -0) 📝 `models/gpg_key_test.go` (+116 -0) 📝 `options/locale/locale_en-US.ini` (+10 -0) 📝 `public/css/index.css` (+33 -2) 📝 `public/less/_repository.less` (+37 -2) 📝 `routers/api/v1/convert/convert.go` (+7 -0) 📝 `routers/repo/commit.go` (+5 -0) 📝 `templates/repo/commits_table.tmpl` (+16 -3) 📝 `templates/repo/diff/page.tmpl` (+17 -2) 📝 `vendor/code.gitea.io/git/commit.go` (+20 -0) 📝 `vendor/code.gitea.io/git/repo_commit.go` (+6 -0) 📝 `vendor/code.gitea.io/sdk/gitea/hook.go` (+15 -6) 📝 `vendor/code.gitea.io/sdk/gitea/user_gpgkey.go` (+6 -0) 📝 `vendor/vendor.json` (+6 -6) </details> ### 📄 Description Display signed commit and validation against gpg key in database. I have started with a very little UI with the a simple title attr indicating the reason. Examples: ![capture d ecran_2017-03-12_23-29-23](https://cloud.githubusercontent.com/assets/4052400/23836749/797684fa-077d-11e7-8ff2-f1861e15e108.png) For comparison : https://github.com/sapk/testing-git/commits/master Need and follow : #710 ✅ go-gitea/git#36 ✅ TODO List : - [x] UI of commits list - [x] UI of commit page - [x] UI file history (same as commits list) - [x] UI search commit (same as commits list) - [x] UI diff commit list (same as commits list) - [x] Add support for translation of new strings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:54:35 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15788