[PR #1143] [CLOSED] Always put OAuth user info in the ExternalLoginUser table #15785

New Issue

GiteaMirror · 2025-11-02T11:54:31-06:00

GiteaMirror commented

2025-11-02 11:54:31 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1143
Author: @strk
Created: 3/7/2017
Status: ❌ Closed

Base: main ← Head: local-source-oauth-users

📝 Commits (3)

b09c73b Always put OAuth user info in the ExternalLoginUser table
924f5ab OAuth2 user is always local
3e9c71e Update test

📊 Changes

4 files changed (+18 additions, -39 deletions)

View changed files

📝 models/action_test.go (+1 -1)
📝 models/user.go (+0 -5)
📝 routers/user/auth.go (+16 -32)
📝 templates/user/settings/account.tmpl (+1 -1)

📄 Description

Never set OAuth in User.LoginSource, which keeps referring to
the username/password interpretation. Fixes #1124

\cc @willemvd, @morrildl, @lunny, @bkcsoft

I think this should be done before 1.1.0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1143 **Author:** [@strk](https://github.com/strk) **Created:** 3/7/2017 **Status:** ❌ Closed **Base:** `main` ← **Head:** `local-source-oauth-users` --- ### 📝 Commits (3) - [`b09c73b`](https://github.com/go-gitea/gitea/commit/b09c73b31e6c5d11f427579cb4a2cc98e962d46e) Always put OAuth user info in the ExternalLoginUser table - [`924f5ab`](https://github.com/go-gitea/gitea/commit/924f5abf9097088926dddaa3ed12f99eec7e00d1) OAuth2 user is always local - [`3e9c71e`](https://github.com/go-gitea/gitea/commit/3e9c71eace1284641bc75120fdd7ad1030a8b9a7) Update test ### 📊 Changes **4 files changed** (+18 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `models/action_test.go` (+1 -1) 📝 `models/user.go` (+0 -5) 📝 `routers/user/auth.go` (+16 -32) 📝 `templates/user/settings/account.tmpl` (+1 -1) </details> ### 📄 Description Never set OAuth in User.LoginSource, which keeps referring to the username/password interpretation. Fixes #1124 \cc @willemvd, @morrildl, @lunny, @bkcsoft I think this should be done before 1.1.0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:54:31 -06:00

GiteaMirror closed this issue

2025-11-02 11:54:32 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15785