[PR #1080] [MERGED] Optimize and unit test Issue_ReplaceLabels #15754

Closed
opened 2025-11-02 11:53:49 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1080
Author: @ethantkoenig
Created: 2/27/2017
Status: Merged
Merged: 2/28/2017
Merged by: @lunny

Base: masterHead: refactor/issue


📝 Commits (1)

  • 27c53b8 Optimize and unit test Issue_ReplaceLabels

📊 Changes

3 files changed (+57 additions, -30 deletions)

View changed files

📝 models/issue.go (+18 -27)
models/issue_test.go (+35 -0)
📝 models/setup_for_test.go (+4 -3)

📄 Description

Refactor out 2 "quadratic" loops in favor of 1 "linear" loop. Also add unit tests to make sure I didn't break anything 😄


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1080 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 2/27/2017 **Status:** ✅ Merged **Merged:** 2/28/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `refactor/issue` --- ### 📝 Commits (1) - [`27c53b8`](https://github.com/go-gitea/gitea/commit/27c53b856e8219ec849ada4b55dc42c70d7a142b) Optimize and unit test Issue_ReplaceLabels ### 📊 Changes **3 files changed** (+57 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `models/issue.go` (+18 -27) ➕ `models/issue_test.go` (+35 -0) 📝 `models/setup_for_test.go` (+4 -3) </details> ### 📄 Description Refactor out 2 "quadratic" loops in favor of 1 "linear" loop. Also add unit tests to make sure I didn't break anything :smile: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:53:49 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15754