github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-11 04:23:04 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #1053] [MERGED] Remove test that touch network #15736

New Issue
Closed
opened 2025-11-02 11:53:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:53:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1053
Author: @andreynering
Created: 2/25/2017
Status: ✅ Merged
Merged: 2/25/2017
Merged by: @andreynering

Base: master ← Head: do-not-test-libravatar

📝 Commits (1)

  • f552b0a Remove test that touch network

📊 Changes

1 file changed (+2 additions, -14 deletions)

View changed files

📝 modules/base/tool_test.go (+2 -14)

📄 Description

This test fails on my machine but passes on CI. I don't know why, but tests that touch external network services are not nice.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1053 **Author:** [@andreynering](https://github.com/andreynering) **Created:** 2/25/2017 **Status:** ✅ Merged **Merged:** 2/25/2017 **Merged by:** [@andreynering](https://github.com/andreynering) **Base:** `master` ← **Head:** `do-not-test-libravatar` --- ### 📝 Commits (1) - [`f552b0a`](https://github.com/go-gitea/gitea/commit/f552b0a20796dfe09498cd636d58abbbe49fad23) Remove test that touch network ### 📊 Changes **1 file changed** (+2 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `modules/base/tool_test.go` (+2 -14) </details> ### 📄 Description This test fails on my machine but passes on CI. I don't know why, but tests that touch external network services are not nice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:53:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15736
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?