[PR #960] [MERGED] Remove the default console logger when it is not set in the configuration #15681

Closed
opened 2025-11-02 11:52:12 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/960
Author: @lunny
Created: 2/16/2017
Status: Merged
Merged: 2/18/2017
Merged by: @lunny

Base: release/v1.0Head: lunny/console_logger


📝 Commits (1)

  • aacad55 Remove the default console logger when it is not set in the configuration (#602)

📊 Changes

2 files changed (+21 additions, -0 deletions)

View changed files

📝 modules/log/log.go (+11 -0)
📝 modules/setting/setting.go (+10 -0)

📄 Description

backport from #602

  • Remove the default console logger when it is not set in the configuration

  • Added comment to new function (lint failure)

  • update based on PR comments (code style)

  • code style fix (thanks bkcsoft)

  • check if logger exists based on the l.outputs (like in l.DelLogger) instead of adapter, otherwise panic when reinstalling gitea (since the output adapter still exist, without outputs)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/960 **Author:** [@lunny](https://github.com/lunny) **Created:** 2/16/2017 **Status:** ✅ Merged **Merged:** 2/18/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `release/v1.0` ← **Head:** `lunny/console_logger` --- ### 📝 Commits (1) - [`aacad55`](https://github.com/go-gitea/gitea/commit/aacad55c7e3a8f32b5041875201a8d01368fb901) Remove the default console logger when it is not set in the configuration (#602) ### 📊 Changes **2 files changed** (+21 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `modules/log/log.go` (+11 -0) 📝 `modules/setting/setting.go` (+10 -0) </details> ### 📄 Description backport from #602 * Remove the default console logger when it is not set in the configuration * Added comment to new function (lint failure) * update based on PR comments (code style) * code style fix (thanks bkcsoft) * check if logger exists based on the l.outputs (like in l.DelLogger) instead of adapter, otherwise panic when reinstalling gitea (since the output adapter still exist, without outputs) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:52:12 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15681