[PR #867] [MERGED] Use assert in legacy unit tests #15622

New Issue

GiteaMirror · 2025-11-02T11:50:54-06:00

GiteaMirror commented

2025-11-02 11:50:54 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/867
Author: @ethantkoenig
Created: 2/8/2017
Status: ✅ Merged
Merged: 2/8/2017
Merged by: @lunny

Base: master ← Head: refactor_tests

📝 Commits (1)

93a05fd Use assert in legacy unit tests

📊 Changes

69 files changed (+237 additions, -6971 deletions)

View changed files

📝 models/models_test.go (+11 -19)
📝 models/repo_test.go (+30 -59)
📝 models/ssh_key_test.go (+22 -35)
📝 modules/avatar/avatar_test.go (+5 -9)
📝 modules/markdown/markdown_test.go (+169 -281)
➖ vendor/github.com/smartystreets/assertions/CONTRIBUTING.md (+0 -12)
➖ vendor/github.com/smartystreets/assertions/LICENSE.md (+0 -23)
➖ vendor/github.com/smartystreets/assertions/README.md (+0 -575)
➖ vendor/github.com/smartystreets/assertions/assertions.goconvey (+0 -3)
➖ vendor/github.com/smartystreets/assertions/collections.go (+0 -244)
➖ vendor/github.com/smartystreets/assertions/doc.go (+0 -105)
➖ vendor/github.com/smartystreets/assertions/equality.go (+0 -280)
➖ vendor/github.com/smartystreets/assertions/filter.go (+0 -23)
➖ vendor/github.com/smartystreets/assertions/internal/go-render/LICENSE (+0 -27)
➖ vendor/github.com/smartystreets/assertions/internal/go-render/render/render.go (+0 -477)
➖ vendor/github.com/smartystreets/assertions/internal/oglematchers/LICENSE (+0 -202)
➖ vendor/github.com/smartystreets/assertions/internal/oglematchers/README.md (+0 -58)
➖ vendor/github.com/smartystreets/assertions/internal/oglematchers/all_of.go (+0 -70)
➖ vendor/github.com/smartystreets/assertions/internal/oglematchers/any.go (+0 -32)
➖ vendor/github.com/smartystreets/assertions/internal/oglematchers/any_of.go (+0 -94)

...and 49 more files

📄 Description

Replace usage of the convey testing tool with the assert library for consistency. Also allows us to remove some dependencies 😄

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/867 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 2/8/2017 **Status:** ✅ Merged **Merged:** 2/8/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `refactor_tests` --- ### 📝 Commits (1) - [`93a05fd`](https://github.com/go-gitea/gitea/commit/93a05fd6fd2e76b12e9b89c9bf7cf8418932b342) Use assert in legacy unit tests ### 📊 Changes **69 files changed** (+237 additions, -6971 deletions) <details> <summary>View changed files</summary> 📝 `models/models_test.go` (+11 -19) 📝 `models/repo_test.go` (+30 -59) 📝 `models/ssh_key_test.go` (+22 -35) 📝 `modules/avatar/avatar_test.go` (+5 -9) 📝 `modules/markdown/markdown_test.go` (+169 -281) ➖ `vendor/github.com/smartystreets/assertions/CONTRIBUTING.md` (+0 -12) ➖ `vendor/github.com/smartystreets/assertions/LICENSE.md` (+0 -23) ➖ `vendor/github.com/smartystreets/assertions/README.md` (+0 -575) ➖ `vendor/github.com/smartystreets/assertions/assertions.goconvey` (+0 -3) ➖ `vendor/github.com/smartystreets/assertions/collections.go` (+0 -244) ➖ `vendor/github.com/smartystreets/assertions/doc.go` (+0 -105) ➖ `vendor/github.com/smartystreets/assertions/equality.go` (+0 -280) ➖ `vendor/github.com/smartystreets/assertions/filter.go` (+0 -23) ➖ `vendor/github.com/smartystreets/assertions/internal/go-render/LICENSE` (+0 -27) ➖ `vendor/github.com/smartystreets/assertions/internal/go-render/render/render.go` (+0 -477) ➖ `vendor/github.com/smartystreets/assertions/internal/oglematchers/LICENSE` (+0 -202) ➖ `vendor/github.com/smartystreets/assertions/internal/oglematchers/README.md` (+0 -58) ➖ `vendor/github.com/smartystreets/assertions/internal/oglematchers/all_of.go` (+0 -70) ➖ `vendor/github.com/smartystreets/assertions/internal/oglematchers/any.go` (+0 -32) ➖ `vendor/github.com/smartystreets/assertions/internal/oglematchers/any_of.go` (+0 -94) _...and 49 more files_ </details> ### 📄 Description Replace usage of the `convey` testing tool with the `assert` library for consistency. Also allows us to remove some dependencies :smile: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:50:54 -06:00

GiteaMirror closed this issue

2025-11-02 11:50:54 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15622