[PR #866] [MERGED] Fix consistency check #15621

New Issue

GiteaMirror · 2025-11-02T11:50:52-06:00

GiteaMirror commented

2025-11-02 11:50:52 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/866
Author: @ethantkoenig
Created: 2/8/2017
Status: ✅ Merged
Merged: 2/8/2017
Merged by: @lunny

Base: master ← Head: consistency

📝 Commits (1)

ca9cd39 Fix consistency check

📊 Changes

4 files changed (+27 additions, -10 deletions)

View changed files

📝 models/consistency_test.go (+17 -8)
📝 models/fixtures/issue.yml (+1 -1)
📝 models/fixtures/repository.yml (+1 -1)
📝 models/issue_label_test.go (+8 -0)

📄 Description

The repo.NumIssues is the number of non-pull-request issues, whereas I had previously thought it was the total number of pull-request-or-non-pull-request issues.

Also a similar fix for repo.NumComments too, and more thorough consistency testing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/866 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 2/8/2017 **Status:** ✅ Merged **Merged:** 2/8/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `consistency` --- ### 📝 Commits (1) - [`ca9cd39`](https://github.com/go-gitea/gitea/commit/ca9cd39041a5f76f920f8f8a2476f75ab04044bd) Fix consistency check ### 📊 Changes **4 files changed** (+27 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `models/consistency_test.go` (+17 -8) 📝 `models/fixtures/issue.yml` (+1 -1) 📝 `models/fixtures/repository.yml` (+1 -1) 📝 `models/issue_label_test.go` (+8 -0) </details> ### 📄 Description The `repo.NumIssues` is the number of non-pull-request issues, whereas I had previously thought it was the total number of pull-request-or-non-pull-request issues. Also a similar fix for `repo.NumComments` too, and more thorough consistency testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:50:52 -06:00

GiteaMirror closed this issue

2025-11-02 11:50:52 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15621