[PR #836] [MERGED] Move IssueUser code to separate file #15599

New Issue

GiteaMirror · 2025-11-02T11:50:20-06:00

GiteaMirror commented

2025-11-02 11:50:20 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/836
Author: @ethantkoenig
Created: 2/3/2017
Status: ✅ Merged
Merged: 2/4/2017
Merged by: @lunny

Base: master ← Head: tests/issue_user

📝 Commits (1)

f05f313 Move IssueUser code to separate file

📊 Changes

6 files changed (+226 additions, -126 deletions)

View changed files

📝 models/fixtures/issue.yml (+1 -0)
➕ models/fixtures/issue_user.yml (+23 -0)
📝 models/issue.go (+0 -125)
➕ models/issue_user.go (+113 -0)
➕ models/issue_user_test.go (+74 -0)
📝 models/setup_for_test.go (+15 -1)

📄 Description

IMO, our code is cleaner and easier to test with small files (such as models/issue_user.go) that are limited in scope.

Also add unit tests for models/issue_user.go), and removes the unused function NewIssueUsers(..).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/836 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 2/3/2017 **Status:** ✅ Merged **Merged:** 2/4/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `tests/issue_user` --- ### 📝 Commits (1) - [`f05f313`](https://github.com/go-gitea/gitea/commit/f05f3136555e7c8cf5aaf6f634818a6871eea4f3) Move IssueUser code to separate file ### 📊 Changes **6 files changed** (+226 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `models/fixtures/issue.yml` (+1 -0) ➕ `models/fixtures/issue_user.yml` (+23 -0) 📝 `models/issue.go` (+0 -125) ➕ `models/issue_user.go` (+113 -0) ➕ `models/issue_user_test.go` (+74 -0) 📝 `models/setup_for_test.go` (+15 -1) </details> ### 📄 Description IMO, our code is cleaner and easier to test with small files (such as `models/issue_user.go`) that are limited in scope. Also add unit tests for `models/issue_user.go`), and removes the unused function `NewIssueUsers(..)`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:50:20 -06:00

GiteaMirror closed this issue

2025-11-02 11:50:20 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15599