[PR #802] [MERGED] Unit tests for models/issue_label #15582

New Issue

GiteaMirror · 2025-11-02T11:49:56-06:00

GiteaMirror commented

2025-11-02 11:49:56 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/802
Author: @ethantkoenig
Created: 1/31/2017
Status: ✅ Merged
Merged: 2/1/2017
Merged by: @lunny

Base: master ← Head: tests/issue_label

📝 Commits (1)

f0d48da Bug fixes and unit tests for models/issue_label

📊 Changes

8 files changed (+301 additions, -14 deletions)

View changed files

➕ models/fixtures/comment.yml (+7 -0)
📝 models/fixtures/issue.yml (+10 -0)
➕ models/fixtures/issue_label.yml (+14 -0)
➕ models/fixtures/label.yml (+15 -0)
📝 models/issue.go (+2 -2)
📝 models/issue_label.go (+8 -11)
➕ models/issue_label_test.go (+244 -0)
📝 routers/api/v1/repo/issue_label.go (+1 -1)

📄 Description

Fixes a bug in deleteIssueLabel(..) that incorrectly decremented label.NumIssues and label.NumClosedIssues.

Also makes a couple small tweaks to models/issue_label.go:

Have getLabelInRepoByName(..) and getLabelInRepoByName(..) use their e arguments (previously were not used).
Remove the unused GetIssueLabels(..) function.
Reorder the arguments to deleteIssueLabel(..) and DeleteIssueLabel(..) to match newIssueLabel(..), NewIssueLabel(..), NewIssueLabels(..) and newIssueLabels(..).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/802 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 1/31/2017 **Status:** ✅ Merged **Merged:** 2/1/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `tests/issue_label` --- ### 📝 Commits (1) - [`f0d48da`](https://github.com/go-gitea/gitea/commit/f0d48da338ce42af8285f9fc8662677ee8023abd) Bug fixes and unit tests for models/issue_label ### 📊 Changes **8 files changed** (+301 additions, -14 deletions) <details> <summary>View changed files</summary> ➕ `models/fixtures/comment.yml` (+7 -0) 📝 `models/fixtures/issue.yml` (+10 -0) ➕ `models/fixtures/issue_label.yml` (+14 -0) ➕ `models/fixtures/label.yml` (+15 -0) 📝 `models/issue.go` (+2 -2) 📝 `models/issue_label.go` (+8 -11) ➕ `models/issue_label_test.go` (+244 -0) 📝 `routers/api/v1/repo/issue_label.go` (+1 -1) </details> ### 📄 Description Fixes a bug in `deleteIssueLabel(..)` that incorrectly decremented `label.NumIssues` and `label.NumClosedIssues`. Also makes a couple small tweaks to `models/issue_label.go`: 1. Have `getLabelInRepoByName(..)` and `getLabelInRepoByName(..)` use their `e` arguments (previously were not used). 2. Remove the unused `GetIssueLabels(..)` function. 3. Reorder the arguments to `deleteIssueLabel(..)` and `DeleteIssueLabel(..)` to match `newIssueLabel(..)`, `NewIssueLabel(..)`, `NewIssueLabels(..)` and `newIssueLabels(..)`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:49:56 -06:00

GiteaMirror closed this issue

2025-11-02 11:49:56 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15582