github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-24 09:38:00 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #704] [MERGED] fix: delete attachment after remove comment. #15533

New Issue
Closed
opened 2025-11-02 11:48:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:48:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/704
Author: @appleboy
Created: 1/20/2017
Status: ✅ Merged
Merged: 1/25/2017
Merged by: @bkcsoft

Base: master ← Head: bugs

📝 Commits (1)

  • 6fa0096 fix: delete attachment after remove comment.

📊 Changes

5 files changed (+11 additions, -7 deletions)

View changed files

📝 models/issue_comment.go (+3 -1)
📝 vendor/github.com/go-xorm/xorm/engine.go (+3 -1)
📝 vendor/github.com/go-xorm/xorm/session_delete.go (+1 -1)
📝 vendor/github.com/go-xorm/xorm/session_update.go (+1 -1)
📝 vendor/vendor.json (+3 -3)

📄 Description

We need to merge XORM bugs first https://github.com/go-xorm/xorm/pull/525 and also update vendor files.

ref: https://github.com/go-gitea/gitea/issues/677#issuecomment-273945141

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/704 **Author:** [@appleboy](https://github.com/appleboy) **Created:** 1/20/2017 **Status:** ✅ Merged **Merged:** 1/25/2017 **Merged by:** [@bkcsoft](https://github.com/bkcsoft) **Base:** `master` ← **Head:** `bugs` --- ### 📝 Commits (1) - [`6fa0096`](https://github.com/go-gitea/gitea/commit/6fa0096ef62ef7df8c05d4c86cdd8104e7a19e83) fix: delete attachment after remove comment. ### 📊 Changes **5 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `models/issue_comment.go` (+3 -1) 📝 `vendor/github.com/go-xorm/xorm/engine.go` (+3 -1) 📝 `vendor/github.com/go-xorm/xorm/session_delete.go` (+1 -1) 📝 `vendor/github.com/go-xorm/xorm/session_update.go` (+1 -1) 📝 `vendor/vendor.json` (+3 -3) </details> ### 📄 Description We need to merge XORM bugs first https://github.com/go-xorm/xorm/pull/525 and also update vendor files. ref: https://github.com/go-gitea/gitea/issues/677#issuecomment-273945141 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:48:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?