github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-21 20:35:31 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #602] [MERGED] Remove the default console logger when it is not set in the configuration #15482

New Issue
Closed
opened 2025-11-02 11:47:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:47:32 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/602
Author: @willemvd
Created: 1/6/2017
Status: ✅ Merged
Merged: 1/17/2017
Merged by: @lunny

Base: master ← Head: master

📝 Commits (5)

  • eb09b63 Remove the default console logger when it is not set in the configuration
  • 3749eaf Added comment to new function (lint failure)
  • e22626d update based on PR comments (code style)
  • b6ca28d code style fix (thanks bkcsoft)
  • c39918c check if logger exists based on the l.outputs (like in l.DelLogger) instead of adapter, otherwise panic when reinstalling gitea (since the output adapter still exist, without outputs)

📊 Changes

2 files changed (+21 additions, -0 deletions)

View changed files

📝 modules/log/log.go (+11 -0)
📝 modules/setting/setting.go (+10 -0)

📄 Description

Fix for issue #581
Removes the default console logger when it is not set in the configuration

Mark: this is my first Go programming experience so please be gentle ;)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/602 **Author:** [@willemvd](https://github.com/willemvd) **Created:** 1/6/2017 **Status:** ✅ Merged **Merged:** 1/17/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`eb09b63`](https://github.com/go-gitea/gitea/commit/eb09b6325debc6698f0b8713caa0c66b42fda942) Remove the default console logger when it is not set in the configuration - [`3749eaf`](https://github.com/go-gitea/gitea/commit/3749eaf82bbf962d12cada4e79b66b568cc1268c) Added comment to new function (lint failure) - [`e22626d`](https://github.com/go-gitea/gitea/commit/e22626d20c58647343820b62b53e6f3df5e97ec8) update based on PR comments (code style) - [`b6ca28d`](https://github.com/go-gitea/gitea/commit/b6ca28ddc2c0187a33a1ae3cb523b1ecf7017885) code style fix (thanks bkcsoft) - [`c39918c`](https://github.com/go-gitea/gitea/commit/c39918c9ca1776646d21c6ff01594dd49e9f3273) check if logger exists based on the l.outputs (like in l.DelLogger) instead of adapter, otherwise panic when reinstalling gitea (since the output adapter still exist, without outputs) ### 📊 Changes **2 files changed** (+21 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `modules/log/log.go` (+11 -0) 📝 `modules/setting/setting.go` (+10 -0) </details> ### 📄 Description Fix for issue #581 Removes the default console logger when it is not set in the configuration Mark: this is my first Go programming experience so please be gentle ;) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:47:32 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15482
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?