github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

XSS in issue and PR titles #1533

New Issue
Closed
opened 2025-11-02 04:04:04 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 04:04:04 -06:00
Owner
Copy Link

Originally created by @pgaskin on GitHub (Feb 14, 2018).

Description

I discovered this issue while using my gitea instance.

When editing a title, it appears in the comments (user changed title to .....), which does not sanitize the html.

Demo (it's safe, just shows a message): https://try.gitea.io/geek1011/XSS/issues/2

Originally created by @pgaskin on GitHub (Feb 14, 2018). - Gitea version (or commit ref): 4c9d9c221a0628753f3dc16b469330ee096cbf18 - Can you reproduce the bug at https://try.gitea.io: - [X] Yes (provide example URL) - [ ] No - [ ] Not relevant ## Description I discovered this issue while using my gitea instance. When editing a title, it appears in the comments (`user changed title to .....`), which does not sanitize the html. Demo (it's safe, just shows a message): https://try.gitea.io/geek1011/XSS/issues/2
GiteaMirror added the topic/securitytype/bug labels 2025-11-02 04:04:04 -06:00
GiteaMirror commented 2025-11-02 04:04:04 -06:00
Author
Owner
Copy Link

@pgaskin commented on GitHub (Feb 14, 2018):

To fix this issue, a translation (issue.change_title_at) needs to be changed, because it includes a <b> tag, which requires the use of the Safe filter, which skips sanitizing the HTML. After the translation and the template is changed, the title does not need to skip sanitation anymore.

@pgaskin commented on GitHub (Feb 14, 2018): To fix this issue, a translation (`issue.change_title_at`) needs to be changed, because it includes a `<b>` tag, which requires the use of the `Safe` filter, which skips sanitizing the HTML. After the translation and the template is changed, the title does not need to skip sanitation anymore.
GiteaMirror commented 2025-11-02 04:04:05 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Feb 14, 2018):

Title can be escaped separately

@lafriks commented on GitHub (Feb 14, 2018): Title can be escaped separately
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/security type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?