[PR #349] [MERGED] Fix regression in #248 #15326

New Issue

GiteaMirror · 2025-11-02T11:44:05-06:00

GiteaMirror commented

2025-11-02 11:44:05 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/349
Author: @bkcsoft
Created: 12/5/2016
Status: ✅ Merged
Merged: 12/5/2016
Merged by: @bkcsoft

Base: master ← Head: bkcsoft/344-fix-close-pr-regression

📝 Commits (3)

167d12e Fix #344 (regression in #248)
ee27c23 Actually fix the error 😆
a7485b4 Change log-msg for #349

📊 Changes

1 file changed (+39 additions, -7 deletions)

View changed files

📝 models/pull.go (+39 -7)

📄 Description

This fixes a regression in #248 where Closing a PR in the WebUI make gitea throw a panic.

Closes #344

It fixes the problem, PRs can now be closed in WebUI, ~~but it still spits out error-logs in the console...~~ Doesn't do this anymore since I'm actually populating the Head/BaseRepo now 😈

Started POST /toor/foobar/issues/1/comments for [::1]
[D] Session ID: 6aa78f141f0be42a
[D] CSRF Token: EVvkiIBTdh2Js1LIMFOoBLjP84s6MTQ4MDkyNzI1MTYxMjU2ODk0Mw==
[T] Issue [1] status changed to closed: true
[T] DeliverHooks [repo_id: 1]
Completed /toor/foobar/issues/1/comments 302 Found in 36.378904ms

Started GET /toor/foobar/pulls/1 for [::1]
[D] Session ID: 6aa78f141f0be42a
[D] CSRF Token: EVvkiIBTdh2Js1LIMFOoBLjP84s6MTQ4MDkyNzI1MTYxMjU2ODk0Mw==
[D] Template: repo/issue/view
Completed /toor/foobar/pulls/1 200 OK in 57.302163ms

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/349 **Author:** [@bkcsoft](https://github.com/bkcsoft) **Created:** 12/5/2016 **Status:** ✅ Merged **Merged:** 12/5/2016 **Merged by:** [@bkcsoft](https://github.com/bkcsoft) **Base:** `master` ← **Head:** `bkcsoft/344-fix-close-pr-regression` --- ### 📝 Commits (3) - [`167d12e`](https://github.com/go-gitea/gitea/commit/167d12ec89db89281fa3f9d3b9fb0dc11210af74) Fix #344 (regression in #248) - [`ee27c23`](https://github.com/go-gitea/gitea/commit/ee27c23fa040de31b4c0c819a0019d1a5177c916) Actually fix the error :laughing: - [`a7485b4`](https://github.com/go-gitea/gitea/commit/a7485b49dcfab54f5280c63adb1e57fb4cffdb4c) Change log-msg for #349 ### 📊 Changes **1 file changed** (+39 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `models/pull.go` (+39 -7) </details> ### 📄 Description This fixes a regression in #248 where Closing a PR in the WebUI make gitea throw a panic. Closes #344 It fixes the problem, PRs can now be closed in WebUI, ~but it still spits out error-logs in the console...~ Doesn't do this anymore since I'm _actually_ populating the Head/BaseRepo now 😈 ``` Started POST /toor/foobar/issues/1/comments for [::1] [D] Session ID: 6aa78f141f0be42a [D] CSRF Token: EVvkiIBTdh2Js1LIMFOoBLjP84s6MTQ4MDkyNzI1MTYxMjU2ODk0Mw== [T] Issue [1] status changed to closed: true [T] DeliverHooks [repo_id: 1] Completed /toor/foobar/issues/1/comments 302 Found in 36.378904ms Started GET /toor/foobar/pulls/1 for [::1] [D] Session ID: 6aa78f141f0be42a [D] CSRF Token: EVvkiIBTdh2Js1LIMFOoBLjP84s6MTQ4MDkyNzI1MTYxMjU2ODk0Mw== [D] Template: repo/issue/view Completed /toor/foobar/pulls/1 200 OK in 57.302163ms ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:44:05 -06:00

GiteaMirror closed this issue

2025-11-02 11:44:05 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15326