[PR #314] [MERGED] Integrate templates into bindata optionally #15300

New Issue

GiteaMirror · 2025-11-02T11:43:29-06:00

GiteaMirror commented

2025-11-02 11:43:29 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/314
Author: @tboerger
Created: 11/30/2016
Status: ✅ Merged
Merged: 12/6/2016
Merged by: @tboerger

Base: master ← Head: templates-bindata

📝 Commits (10+)

3d64072 Ignore templates bindata
3c76da9 Integrated dynamic and static bindata for templates
884f49d Dropped the template version check
b5af25b Dropped the dependency version checks
ee0ed22 Fixed templates import paths
d9e456f Use the optional embedded templates
af1d48f Drop the prefix from public bindata
1626da0 Started to integrate mail templates
2ddb596 This is how you do it
971de3a Moved highlight helper into separate module

📊 Changes

15 files changed (+274 additions, -107 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 cmd/web.go (+3 -55)
📝 models/git_diff.go (+1 -1)
📝 models/mail.go (+37 -42)
📝 modules/highlight/highlight.go (+0 -0)
📝 modules/public/public.go (+2 -0)
📝 modules/public/static.go (+1 -1)
➕ modules/templates/dynamic.go (+103 -0)
📝 modules/templates/helper.go (+1 -1)
➕ modules/templates/static.go (+109 -0)
➕ modules/templates/templates.go (+10 -0)
📝 routers/init.go (+1 -1)
📝 routers/repo/editor.go (+2 -2)
📝 routers/repo/view.go (+3 -3)
➖ templates/.VERSION (+0 -1)

📄 Description

I have created this pull request to get early feedback. To finish this PR I still need to figure out how we can use the embedded templates for the mailer. Looks like the used macaron.TemplateSet doesn't like bindata.

Partially obsoletes https://github.com/go-gitea/gitea/pull/74.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/314 **Author:** [@tboerger](https://github.com/tboerger) **Created:** 11/30/2016 **Status:** ✅ Merged **Merged:** 12/6/2016 **Merged by:** [@tboerger](https://github.com/tboerger) **Base:** `master` ← **Head:** `templates-bindata` --- ### 📝 Commits (10+) - [`3d64072`](https://github.com/go-gitea/gitea/commit/3d640728c3a98de488f50ed82e17abef35b4c441) Ignore templates bindata - [`3c76da9`](https://github.com/go-gitea/gitea/commit/3c76da96adee39eed9cf8857b4d7a2fb7eb9597b) Integrated dynamic and static bindata for templates - [`884f49d`](https://github.com/go-gitea/gitea/commit/884f49dc689683025bce4001727aaaa0b6650bf4) Dropped the template version check - [`b5af25b`](https://github.com/go-gitea/gitea/commit/b5af25b73d1b66df6995a6889c75abe3ca6885bf) Dropped the dependency version checks - [`ee0ed22`](https://github.com/go-gitea/gitea/commit/ee0ed2230fe061218b7fea2d79749154487a2807) Fixed templates import paths - [`d9e456f`](https://github.com/go-gitea/gitea/commit/d9e456fcc959f02f721d7fcd447223495125228c) Use the optional embedded templates - [`af1d48f`](https://github.com/go-gitea/gitea/commit/af1d48f1ca9b8770d406ec71ce6f687274c58502) Drop the prefix from public bindata - [`1626da0`](https://github.com/go-gitea/gitea/commit/1626da033737526f6f3284e136dd2136e34dca0d) Started to integrate mail templates - [`2ddb596`](https://github.com/go-gitea/gitea/commit/2ddb59699cf7bde528130fc6d8fa7034ed4ffe0c) This is how you do it - [`971de3a`](https://github.com/go-gitea/gitea/commit/971de3ae0db7c9cc9bdabb2efa7ba31c7e32ecc4) Moved highlight helper into separate module ### 📊 Changes **15 files changed** (+274 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `cmd/web.go` (+3 -55) 📝 `models/git_diff.go` (+1 -1) 📝 `models/mail.go` (+37 -42) 📝 `modules/highlight/highlight.go` (+0 -0) 📝 `modules/public/public.go` (+2 -0) 📝 `modules/public/static.go` (+1 -1) ➕ `modules/templates/dynamic.go` (+103 -0) 📝 `modules/templates/helper.go` (+1 -1) ➕ `modules/templates/static.go` (+109 -0) ➕ `modules/templates/templates.go` (+10 -0) 📝 `routers/init.go` (+1 -1) 📝 `routers/repo/editor.go` (+2 -2) 📝 `routers/repo/view.go` (+3 -3) ➖ `templates/.VERSION` (+0 -1) </details> ### 📄 Description I have created this pull request to get early feedback. To finish this PR I still need to figure out how we can use the embedded templates for the mailer. Looks like the used macaron.TemplateSet doesn't like bindata. Partially obsoletes https://github.com/go-gitea/gitea/pull/74. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:43:29 -06:00

GiteaMirror closed this issue

2025-11-02 11:43:29 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15300