[PR #300] [MERGED] webhook tag sha fix (#286) #15297

New Issue

GiteaMirror · 2025-11-02T11:43:25-06:00

GiteaMirror commented

2025-11-02 11:43:25 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/300
Author: @bkcsoft
Created: 11/29/2016
Status: ✅ Merged
Merged: 11/29/2016
Merged by: @bkcsoft

Base: master ← Head: bkcsoft/webhook-tag-sha-fix

📝 Commits (4)

dcf9ef7 Tag-webhooks are useless without shasums
55bd3ed Update gitea/sdk vendor
5e7b220 CreateBranch-hook has shasum. Use the full ref for fetching shasum
d7bfc3c Fix breakage from vendor-update

📊 Changes

34 files changed (+332 additions, -44 deletions)

View changed files

📝 models/action.go (+20 -0)
📝 models/issue.go (+5 -5)
📝 models/pull.go (+1 -1)
📝 models/user.go (+1 -1)
📝 models/webhook_slack.go (+1 -1)
📝 routers/api/v1/convert/convert.go (+1 -1)
📝 routers/api/v1/repo/issue.go (+1 -1)
📝 routers/api/v1/user/user.go (+1 -1)
📝 vendor/code.gitea.io/sdk/gitea/admin_org.go (+1 -0)
📝 vendor/code.gitea.io/sdk/gitea/admin_repo.go (+1 -0)
📝 vendor/code.gitea.io/sdk/gitea/admin_user.go (+6 -0)
➕ vendor/code.gitea.io/sdk/gitea/doc.go (+5 -0)
📝 vendor/code.gitea.io/sdk/gitea/gitea.go (+11 -0)
📝 vendor/code.gitea.io/sdk/gitea/issue.go (+28 -3)
📝 vendor/code.gitea.io/sdk/gitea/issue_comment.go (+20 -5)
📝 vendor/code.gitea.io/sdk/gitea/issue_label.go (+20 -2)
📝 vendor/code.gitea.io/sdk/gitea/issue_milestone.go (+8 -0)
📝 vendor/code.gitea.io/sdk/gitea/miscellaneous.go (+1 -0)
📝 vendor/code.gitea.io/sdk/gitea/org.go (+8 -1)
📝 vendor/code.gitea.io/sdk/gitea/org_member.go (+2 -0)

...and 14 more files

📄 Description

Fixes #286
Depends on go-gitea/go-sdk#21 ~~(Don't merge before I've vendored it!)~~

Tag-hooks are pretty useless without specifying which shasum the new tag points at, this PR fixes that :)

Question: ~~Should we also send the Shasum for "create branch"-events? (need to add another line in that case ^.^ )~~ Yes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/300 **Author:** [@bkcsoft](https://github.com/bkcsoft) **Created:** 11/29/2016 **Status:** ✅ Merged **Merged:** 11/29/2016 **Merged by:** [@bkcsoft](https://github.com/bkcsoft) **Base:** `master` ← **Head:** `bkcsoft/webhook-tag-sha-fix` --- ### 📝 Commits (4) - [`dcf9ef7`](https://github.com/go-gitea/gitea/commit/dcf9ef78794167f9d2ac38e38863f0419d32714e) Tag-webhooks are useless without shasums - [`55bd3ed`](https://github.com/go-gitea/gitea/commit/55bd3edb90285fe5983229defcaec7b49f94b980) Update gitea/sdk vendor - [`5e7b220`](https://github.com/go-gitea/gitea/commit/5e7b2200a82b42be76f06e2eafec08cc2d6b1d5b) CreateBranch-hook has shasum. Use the full ref for fetching shasum - [`d7bfc3c`](https://github.com/go-gitea/gitea/commit/d7bfc3c52673943bd445f671533434876d775673) Fix breakage from vendor-update ### 📊 Changes **34 files changed** (+332 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `models/action.go` (+20 -0) 📝 `models/issue.go` (+5 -5) 📝 `models/pull.go` (+1 -1) 📝 `models/user.go` (+1 -1) 📝 `models/webhook_slack.go` (+1 -1) 📝 `routers/api/v1/convert/convert.go` (+1 -1) 📝 `routers/api/v1/repo/issue.go` (+1 -1) 📝 `routers/api/v1/user/user.go` (+1 -1) 📝 `vendor/code.gitea.io/sdk/gitea/admin_org.go` (+1 -0) 📝 `vendor/code.gitea.io/sdk/gitea/admin_repo.go` (+1 -0) 📝 `vendor/code.gitea.io/sdk/gitea/admin_user.go` (+6 -0) ➕ `vendor/code.gitea.io/sdk/gitea/doc.go` (+5 -0) 📝 `vendor/code.gitea.io/sdk/gitea/gitea.go` (+11 -0) 📝 `vendor/code.gitea.io/sdk/gitea/issue.go` (+28 -3) 📝 `vendor/code.gitea.io/sdk/gitea/issue_comment.go` (+20 -5) 📝 `vendor/code.gitea.io/sdk/gitea/issue_label.go` (+20 -2) 📝 `vendor/code.gitea.io/sdk/gitea/issue_milestone.go` (+8 -0) 📝 `vendor/code.gitea.io/sdk/gitea/miscellaneous.go` (+1 -0) 📝 `vendor/code.gitea.io/sdk/gitea/org.go` (+8 -1) 📝 `vendor/code.gitea.io/sdk/gitea/org_member.go` (+2 -0) _...and 14 more files_ </details> ### 📄 Description Fixes #286 Depends on go-gitea/go-sdk#21 ~(**Don't merge** before I've vendored it!)~ Tag-hooks are pretty useless without specifying which shasum the new tag points at, this PR fixes that :) Question: ~Should we also send the Shasum for "create branch"-events? (need to add another line in that case ^.^ )~ Yes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:43:25 -06:00

GiteaMirror closed this issue

2025-11-02 11:43:25 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15297