[PR #172] [CLOSED] Make bindata.go optional, remove from repository #15203

New Issue

GiteaMirror · 2025-11-02T11:41:13-06:00

GiteaMirror commented

2025-11-02 11:41:13 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/172
Author: @strk
Created: 11/14/2016
Status: ❌ Closed

Base: master ← Head: optional-bindata

📝 Commits (1)

c155be7 Make bindata.go optional, remove from repository

📊 Changes

5 files changed (+173 additions, -5331 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 Makefile (+2 -1)
➖ modules/bindata/bindata.go (+0 -5330)
➕ modules/bindata/dynamic.go (+144 -0)
➕ modules/bindata/dynamic_test.go (+24 -0)

📄 Description

By default will read assets from filesystems, but can embed them
by passing the "bindata" build tag (go build -tags bindata)

Fixes #30

Print a WARNING when bindata is not embedded, and
honours GITEA_WORK_DIR, when given, for finding filesystem assets.

Includes automatic test for the dynamic "bin"data library.

NOTE: an equivalent functionality is planned to be included in a
bigger change by @tboerger currently in progress and tracked as PR #74;
this PR is smaller in scope and ready.

Please keep open until either this or #74 is merged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/172 **Author:** [@strk](https://github.com/strk) **Created:** 11/14/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `optional-bindata` --- ### 📝 Commits (1) - [`c155be7`](https://github.com/go-gitea/gitea/commit/c155be70f4c9d162f18e1858363a1065dccf494f) Make bindata.go optional, remove from repository ### 📊 Changes **5 files changed** (+173 additions, -5331 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `Makefile` (+2 -1) ➖ `modules/bindata/bindata.go` (+0 -5330) ➕ `modules/bindata/dynamic.go` (+144 -0) ➕ `modules/bindata/dynamic_test.go` (+24 -0) </details> ### 📄 Description By default will read assets from filesystems, but can embed them by passing the "bindata" build tag (go build -tags bindata) Fixes #30 Print a WARNING when bindata is not embedded, and honours GITEA_WORK_DIR, when given, for finding filesystem assets. Includes automatic test for the dynamic "bin"data library. NOTE: an equivalent functionality is planned to be included in a bigger change by @tboerger currently in progress and tracked as PR #74; this PR is smaller in scope and ready. Please keep open until either this or #74 is merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:41:13 -06:00

GiteaMirror closed this issue

2025-11-02 11:41:13 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15203