github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-25 07:56:03 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Elasticsearch password print on clear in case of error #14980

New Issue
Closed
opened 2025-11-02 11:27:10 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-02 11:27:10 -06:00
Owner
Copy Link

Originally created by @aarnaud on GitHub (Sep 24, 2025).

Originally assigned to: @shashank-netapp on GitHub.

Description

On startup if gitea failed to init it connection to ElasticSearch, the string connection containing the password is printed.

but we can see that is also masked on an other line.

In this example password is xyz

2025/09/24 16:39:18 .../indexer/issues/indexer.go:103:InitIssueIndexer.1() [F] Unable to issueIndexer.Init with connection http://gitea:xyz@indexer-gitea-es-http:9200 Error: health check timeout: Head "http://gitea:***@indexer-gitea-es-http:9200": EOF: no Elasticsearch node available

Gitea Version

1.24.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Inside Kubernetes

Database

PostgreSQL

Originally created by @aarnaud on GitHub (Sep 24, 2025). Originally assigned to: @shashank-netapp on GitHub. ### Description On startup if gitea failed to init it connection to ElasticSearch, the string connection containing the password is printed. but we can see that is also masked on an other line. In this example password is `xyz` ``` 2025/09/24 16:39:18 .../indexer/issues/indexer.go:103:InitIssueIndexer.1() [F] Unable to issueIndexer.Init with connection http://gitea:xyz@indexer-gitea-es-http:9200 Error: health check timeout: Head "http://gitea:***@indexer-gitea-es-http:9200": EOF: no Elasticsearch node available ``` ### Gitea Version 1.24.5 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Inside Kubernetes ### Database PostgreSQL
GiteaMirror added the type/bugtopic/security labels 2025-11-02 11:27:10 -06:00
GiteaMirror commented 2025-11-02 11:27:11 -06:00
Author
Owner
Copy Link

@shashank-netapp commented on GitHub (Sep 27, 2025):

Can this be assigned to me? I can have a look into it.

@shashank-netapp commented on GitHub (Sep 27, 2025): Can this be assigned to me? I can have a look into it.
GiteaMirror commented 2025-11-02 11:27:11 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Sep 27, 2025):

You can move shadowURL from admin/config.go to modules/util and reuse it. And please also search other possible password leak logs.

@lunny commented on GitHub (Sep 27, 2025): You can move `shadowURL` from admin/config.go to modules/util and reuse it. And please also search other possible password leak logs.
GiteaMirror commented 2025-11-02 11:27:11 -06:00
Author
Owner
Copy Link

@shashank-netapp commented on GitHub (Sep 27, 2025):

Sure, thanks @lunny !!

@shashank-netapp commented on GitHub (Sep 27, 2025): Sure, thanks @lunny !!
GiteaMirror commented 2025-11-02 11:27:12 -06:00
Author
Owner
Copy Link

@shashank-netapp commented on GitHub (Sep 27, 2025):

@lunny, there's a function called SanitizeCredentialURLs under modules/util, which can be used here, without any cyclic import dependency. Any harm in using it ? rather than shadowURL ?

@shashank-netapp commented on GitHub (Sep 27, 2025): @lunny, there's a function called `SanitizeCredentialURLs` under `modules/util`, which can be used here, without any cyclic import dependency. Any harm in using it ? rather than `shadowURL` ?
GiteaMirror commented 2025-11-02 11:27:12 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Sep 27, 2025):

SanitizeCredentialURLs will remove the the credentials as well as shadowURL will replace the password with *. Both are acceptable for me. If you move shadowURL to util. You need to do some adjustment like add a second return parameter error and remove the error log.

@lunny commented on GitHub (Sep 27, 2025): `SanitizeCredentialURLs` will remove the the credentials as well as `shadowURL` will replace the password with `*`. Both are acceptable for me. If you move `shadowURL` to `util`. You need to do some adjustment like add a second return parameter `error` and remove the error log.
GiteaMirror commented 2025-11-02 11:27:12 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Sep 27, 2025):

SanitizeCredentialURLs does much better, more performant and well tested. shadowURL should be removed and replaced.

@wxiaoguang commented on GitHub (Sep 27, 2025): `SanitizeCredentialURLs` does much better, more performant and well tested. `shadowURL` should be removed and replaced.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/security type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14980
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?