github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 11:31:28 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Do Not Write Contents of Secret Files to app.ini #14880

New Issue
Open
opened 2025-11-02 11:25:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:25:01 -06:00
Owner
Copy Link

Originally created by @joebobmiles on GitHub (Aug 19, 2025).

Feature Description

Back in 2023, environment-to-ini was modified to support Docker secrets. However, after reading a secret like the database password from a file, Gitea writes the secret in plaintext to the app.ini file, which is a security concern.

As an example: I have a setup where the database password is encrypted on the host file system. The password is only decrypted when it is passed to Gitea via Docker secrets. Because I also have app.ini mapped to the host file system, Gitea ends up leaking the unencrypted secret back to the host file system in the app.ini.

I'd like to propose that Gitea only stores the *_FILE value for secrets in app.ini and keeps the file contents only in memory.

Screenshots

No response

Originally created by @joebobmiles on GitHub (Aug 19, 2025). ### Feature Description Back in 2023, [environment-to-ini was modified to support Docker secrets](https://github.com/go-gitea/gitea/pull/24832). However, after reading a secret like the database password from a file, Gitea writes the secret in plaintext to the app.ini file, which is a security concern. As an example: I have a setup where the database password is encrypted on the host file system. The password is only decrypted when it is passed to Gitea via Docker secrets. Because I also have app.ini mapped to the host file system, Gitea ends up leaking the unencrypted secret back to the host file system in the app.ini. I'd like to propose that Gitea only stores the *_FILE value for secrets in app.ini and keeps the file contents only in memory. ### Screenshots _No response_
GiteaMirror added the type/proposaltopic/security labels 2025-11-02 11:25:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/security type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14880
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?