github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

upgrade.sh exits with error if Gitea is already the latest version #14877

New Issue
Closed
opened 2025-11-02 11:24:57 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 11:24:57 -06:00
Owner
Copy Link

Originally created by @eric-j-ason on GitHub (Aug 19, 2025).

Description

If everything goes fine, and upgrade.sh concludes that the running version of Gitea already is the latest, it exits with status 1, as if there was an error. It would be as if apt upgrade exited with status 1 whenever all packages were already up to date.

57b8441745/contrib/upgrade.sh (L88)

I suggest exiting with status 0 in this situation.

Gitea Version

57b8441745

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Downloading and running https://github.com/go-gitea/gitea/blob/main/contrib/upgrade.sh.

Database

None

Originally created by @eric-j-ason on GitHub (Aug 19, 2025). ### Description If everything goes fine, and `upgrade.sh` concludes that the running version of Gitea already is the latest, it exits with status 1, as if there was an error. It would be as if `apt upgrade` exited with status 1 whenever all packages were already up to date. https://github.com/go-gitea/gitea/blob/57b84417450fc9c2c87d3cac174ef10766881da3/contrib/upgrade.sh#L88 I suggest exiting with status 0 in this situation. ### Gitea Version 57b84417450fc9c2c87d3cac174ef10766881da3 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Downloading and running <https://github.com/go-gitea/gitea/blob/main/contrib/upgrade.sh>. ### Database None
GiteaMirror added the type/bug label 2025-11-02 11:24:57 -06:00
GiteaMirror commented 2025-11-02 11:24:58 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Aug 19, 2025):

I agree, no upgrade available is not a failure.

@silverwind commented on GitHub (Aug 19, 2025): I agree, no upgrade available is not a failure.
GiteaMirror commented 2025-11-02 11:24:58 -06:00
Author
Owner
Copy Link

@eric-j-ason commented on GitHub (Aug 19, 2025):

I'll just go ahead and make a pull request, that whoever is in charge can accept or reject.

By the way, I notice that the introduction of strict mode (set -euo pipefail) sits halfway through the file. It used to be at the top, which is probably its right place.

463016b317/contrib/upgrade.sh (L61)

@eric-j-ason commented on GitHub (Aug 19, 2025): I'll just go ahead and make a pull request, that whoever is in charge can accept or reject. By the way, I notice that the introduction of strict mode (`set -euo pipefail`) sits halfway through the file. It used to be at the top, which is probably its right place. https://github.com/go-gitea/gitea/blob/463016b31774cacf83df44d0bb580621d2af4020/contrib/upgrade.sh#L61
GiteaMirror commented 2025-11-02 11:24:58 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Aug 19, 2025):

Maybe its because some commands before can fail and we don't want the script to exit because of set -e. If there are failing commands, wrap them in a set +e and set -e to temporarily allow command failures.

@silverwind commented on GitHub (Aug 19, 2025): Maybe its because some commands before can fail and we don't want the script to exit because of `set -e`. If there are failing commands, wrap them in a `set +e` and `set -e` to temporarily allow command failures.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?