github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 04:42:51 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Can token lifetime for actions be a configurable thing? #14840

New Issue
Closed
opened 2025-11-02 11:24:08 -06:00 by GiteaMirror · 8 comments
GiteaMirror commented 2025-11-02 11:24:08 -06:00
Owner
Copy Link

Originally created by @TimB87 on GitHub (Aug 7, 2025).

Description

Hi!

We are building a CI/CD pipeline with rather long running actions, longer that 24h at least.

The invalidated token will produce a http 500 error when uploading the artifact with a final upload-artifact step on the workflow. From giteas server log:

2025/08/01 13:45:44 .../actions/artifacts.go:164:ArtifactsRoutes.ArtifactContexter.2.1() [E] Error runner api getting task: task with token "<token>": resource does not exist
2025/08/01 13:45:44 HTTPRequest [I] router: completed POST /api/actions_pipeline/_apis/pipelines/workflows/473/artifacts?api-version=6.0-preview for <runner_ip>:0, 500 Internal Server Error in 0.2ms @ actions/artifacts.go:127(actions.ArtifactsRoutes.ArtifactContexter)

Is there a reason against making this configurable somehow or is that nothing we should run on the pipeline for reasons I am not seeing yet?

For reference, this is one of the runs that has the problem: https://git.crux.nu/system/crux-rootfs/actions/runs/166

Gitea Version

1.24.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.49.0

Operating System

CRUX

How are you running Gitea?

Self compiled Gitea and started by a rc file (sysvinit system).

Database

PostgreSQL

Originally created by @TimB87 on GitHub (Aug 7, 2025). ### Description Hi! We are building a CI/CD pipeline with rather long running actions, [longer that 24h at least](https://github.com/go-gitea/gitea/blob/main/services/actions/auth.go#L56). The invalidated token will produce a http 500 error when uploading the artifact with a final upload-artifact step on the workflow. From giteas server log: ``` 2025/08/01 13:45:44 .../actions/artifacts.go:164:ArtifactsRoutes.ArtifactContexter.2.1() [E] Error runner api getting task: task with token "<token>": resource does not exist 2025/08/01 13:45:44 HTTPRequest [I] router: completed POST /api/actions_pipeline/_apis/pipelines/workflows/473/artifacts?api-version=6.0-preview for <runner_ip>:0, 500 Internal Server Error in 0.2ms @ actions/artifacts.go:127(actions.ArtifactsRoutes.ArtifactContexter) ``` Is there a reason against making this configurable somehow or is that nothing we should run on the pipeline for reasons I am not seeing yet? For reference, this is one of the runs that has the problem: https://git.crux.nu/system/crux-rootfs/actions/runs/166 ### Gitea Version 1.24.4 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version 2.49.0 ### Operating System CRUX ### How are you running Gitea? Self compiled Gitea and started by a rc file (sysvinit system). ### Database PostgreSQL
GiteaMirror added the topic/gitea-actionstype/bug labels 2025-11-02 11:24:08 -06:00
GiteaMirror commented 2025-11-02 11:24:09 -06:00
Author
Owner
Copy Link

@ChristopherHX commented on GitHub (Aug 7, 2025):

Sounds like this should match ENDLESS_TASK_TIMEOUT that you increased already from 3h including on the runner side.

https://docs.gitea.com/next/administration/config-cheat-sheet?_highlight=cheat#actions-actions

What do you think?

@ChristopherHX commented on GitHub (Aug 7, 2025): Sounds like this should match ENDLESS_TASK_TIMEOUT that you increased already from 3h including on the runner side. https://docs.gitea.com/next/administration/config-cheat-sheet?_highlight=cheat#actions-actions What do you think?
GiteaMirror commented 2025-11-02 11:24:09 -06:00
Author
Owner
Copy Link

@TimB87 commented on GitHub (Aug 7, 2025):

@ChristopherHX We adjusted the ENDLESS_TASK_TIMEOUT to 72h previously but it had no affect for us.
We also raised the timeout values for ZOMBIE_TASK_TIMEOUT and ABANDONED_JOB_TIMEOUT with no effect on this issue, fwiw

@TimB87 commented on GitHub (Aug 7, 2025): @ChristopherHX We adjusted the ENDLESS_TASK_TIMEOUT to 72h previously but it had no affect for us. We also raised the timeout values for ZOMBIE_TASK_TIMEOUT and ABANDONED_JOB_TIMEOUT with no effect on this issue, fwiw
GiteaMirror commented 2025-11-02 11:24:09 -06:00
Author
Owner
Copy Link

@ChristopherHX commented on GitHub (Aug 7, 2025):

We adjusted the ENDLESS_TASK_TIMEOUT to 72h previously but it had no affect for us.

My suggestion is to change this where you quoted to take into account ENDLESS_TASK_TIMEOUT

Such a change could be backport candidate for 1.24.5

@ChristopherHX commented on GitHub (Aug 7, 2025): > We adjusted the ENDLESS_TASK_TIMEOUT to 72h previously but it had no affect for us. My suggestion is to change this where you quoted to take into account ENDLESS_TASK_TIMEOUT Such a change could be backport candidate for 1.24.5
GiteaMirror commented 2025-11-02 11:24:10 -06:00
Author
Owner
Copy Link

@TimB87 commented on GitHub (Aug 8, 2025):

I'll give it a try, thanks!

@TimB87 commented on GitHub (Aug 8, 2025): I'll give it a try, thanks!
GiteaMirror commented 2025-11-02 11:24:10 -06:00
Author
Owner
Copy Link

@TimB87 commented on GitHub (Aug 12, 2025):

@ChristopherHX Can I ask if this is what you had in mind or if this is too simple?

360879ee72

@TimB87 commented on GitHub (Aug 12, 2025): @ChristopherHX Can I ask if this is what you had in mind or if this is too simple? https://github.com/TimB87/gitea/commit/360879ee7289f64d76983ed9b0bf1aa86b0f9aaa
GiteaMirror commented 2025-11-02 11:24:10 -06:00
Author
Owner
Copy Link

@ChristopherHX commented on GitHub (Aug 12, 2025):

@ChristopherHX Can I ask if this is what you had in mind or if this is too simple?

TimB87@360879e

Yes more or less exactly like your commit.

I might reduce the +24h maybe a bit to +1h ≈ +5min, because of the additional time.

@ChristopherHX commented on GitHub (Aug 12, 2025): > [@ChristopherHX](https://github.com/ChristopherHX) Can I ask if this is what you had in mind or if this is too simple? > > [TimB87@360879e](https://github.com/TimB87/gitea/commit/360879ee7289f64d76983ed9b0bf1aa86b0f9aaa) Yes more or less exactly like your commit. I might reduce the +24h maybe a bit to +1h ≈ +5min, because of the additional time.
GiteaMirror commented 2025-11-02 11:24:10 -06:00
Author
Owner
Copy Link

@TimB87 commented on GitHub (Aug 12, 2025):

Thanks!
This sounds reasonable, I'll change it to 1h+EndlessTaskTimeout after testing and confirming that works for us.

@TimB87 commented on GitHub (Aug 12, 2025): Thanks! This sounds reasonable, I'll change it to 1h+EndlessTaskTimeout after testing and confirming that works for us.
GiteaMirror commented 2025-11-02 11:24:11 -06:00
Author
Owner
Copy Link

@TimB87 commented on GitHub (Aug 13, 2025):

My test was successful! Thanks again for the guidance @ChristopherHX!

@TimB87 commented on GitHub (Aug 13, 2025): My test was successful! Thanks again for the guidance @ChristopherHX!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/gitea-actions type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14840
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?