github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-26 04:00:37 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

regression: relative URL paths in .gitmodules no longer produce correct submodule links #14738

New Issue
Closed
opened 2025-11-02 11:21:38 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-02 11:21:38 -06:00
Owner
Copy Link
Copy Source

Originally created by @AdamMajer on GitHub (Jul 10, 2025).

Description

Relative paths in url= elements of .gitmodules used to work with 1.23.7 but now fail to work with 1.24.2 and latest demo. For example,

https://demo.gitea.com/gnuman/rel_submodule_test

The format in .gitmodules is url=../../org/repo instead of url=https://demo.gitea.com/org/repo. The relative path allows one to move repositories to different instance and the checkout will continues to work.

Gitea Version

1.24.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Self-hosted

Database

PostgreSQL

Originally created by @AdamMajer on GitHub (Jul 10, 2025). ### Description Relative paths in `url=` elements of .gitmodules used to work with 1.23.7 but now fail to work with 1.24.2 and latest demo. For example, https://demo.gitea.com/gnuman/rel_submodule_test The format in .gitmodules is `url=../../org/repo` instead of `url=https://demo.gitea.com/org/repo`. The relative path allows one to move repositories to different instance and the checkout will continues to work. ### Gitea Version 1.24.2 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Self-hosted ### Database PostgreSQL
GiteaMirror added the type/bug label 2025-11-02 11:21:38 -06:00
GiteaMirror commented 2025-11-02 11:21:40 -06:00
Author
Owner
Copy Link
Copy Source

@wxiaoguang commented on GitHub (Jul 10, 2025):

Related to add submodule diff links (#33097)

Then it's unable to generate "CommitWebLink" for such "relative path" case.

Maybe we can just keep the relative path

@wxiaoguang commented on GitHub (Jul 10, 2025): Related to add submodule diff links (#33097) Then it's unable to generate "CommitWebLink" for such "relative path" case. --- Maybe we can just keep the relative path
GiteaMirror commented 2025-11-02 11:21:40 -06:00
Author
Owner
Copy Link
Copy Source

@wxiaoguang commented on GitHub (Jul 10, 2025):

I think this one will fix? Make submodule link work with relative path #35034

And added new tests

Image
@wxiaoguang commented on GitHub (Jul 10, 2025): I think this one will fix? Make submodule link work with relative path #35034 And added new tests <img width="1200" height="242" alt="Image" src="https://github.com/user-attachments/assets/400d1861-dd0a-4a69-82d7-29afa23680de" />
GiteaMirror commented 2025-11-02 11:21:41 -06:00
Author
Owner
Copy Link
Copy Source

@AdamMajer commented on GitHub (Jul 14, 2025):

Image

It seems it's still broken in the case of ../docs relative path. So same organization but different repository.

@AdamMajer commented on GitHub (Jul 14, 2025): <img width="480" height="364" alt="Image" src="https://github.com/user-attachments/assets/0e130734-c9a5-49db-a715-09aacd26d969" /> It seems it's still broken in the case of `../docs` relative path. So same organization but different repository.
GiteaMirror commented 2025-11-02 11:21:41 -06:00
Author
Owner
Copy Link
Copy Source

@wxiaoguang commented on GitHub (Jul 14, 2025):

Hmm, the complete is Improve submodule relative path handling #35056 , could you try that fix?

@wxiaoguang commented on GitHub (Jul 14, 2025): Hmm, the complete is Improve submodule relative path handling #35056 , could you try that fix?
GiteaMirror commented 2025-11-02 11:21:41 -06:00
Author
Owner
Copy Link
Copy Source

@AdamMajer commented on GitHub (Jul 14, 2025):

I can confirm that the improved hadling fixes all these problems that I can see. Relative and absolute submodules work well. Thanks!

@AdamMajer commented on GitHub (Jul 14, 2025): I can confirm that the improved hadling fixes all these problems that I can see. Relative and absolute submodules work well. Thanks!
GiteaMirror commented 2025-11-02 11:21:41 -06:00
Author
Owner
Copy Link
Copy Source

@wxiaoguang commented on GitHub (Jul 14, 2025):

And it also makes the submodules that in a sub-directory work, I think that doesn't work in 1.23 😆

@wxiaoguang commented on GitHub (Jul 14, 2025): And it also makes the submodules that in a sub-directory work, I think that doesn't work in 1.23 😆
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No labels type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14738