github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Repo indexer - empty results for specific documents #1461

New Issue
Closed
opened 2025-11-02 04:01:35 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 04:01:35 -06:00
Owner
Copy Link

Originally created by @ghost on GitHub (Jan 16, 2018).

gitea master version number d29aa76

Trying to use repository indexer, I seen that some results for specific documents (like JSP and JRXML), doesn't show the context:

immagine

The line numbers are rights, but not text is showed in result.

To replicate this kind of problem, try to clone this test repo: https://github.com/1212050/Shopping-web-Jsp-Servlet
and try to search for "jsp" text.
You will see:
immagine

Originally created by @ghost on GitHub (Jan 16, 2018). gitea master version number d29aa76 Trying to use repository indexer, I seen that some results for specific documents (like JSP and JRXML), doesn't show the context: ![immagine](https://user-images.githubusercontent.com/6648129/34994357-85213d50-fad3-11e7-8e08-4ef6e44a45b7.png) The line numbers are rights, but not text is showed in result. To replicate this kind of problem, try to clone this test repo: [https://github.com/1212050/Shopping-web-Jsp-Servlet](url) and try to search for "jsp" text. You will see: ![immagine](https://user-images.githubusercontent.com/6648129/34994540-28e74f38-fad4-11e7-81ed-752934521feb.png)
GiteaMirror added the type/bugtopic/security labels 2025-11-02 04:01:35 -06:00
GiteaMirror commented 2025-11-02 04:01:36 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jan 16, 2018):

Maybe an encoding problem?

@lunny commented on GitHub (Jan 16, 2018): Maybe an encoding problem?
GiteaMirror commented 2025-11-02 04:01:36 -06:00
Author
Owner
Copy Link

@thehowl commented on GitHub (Jan 16, 2018):

Hmmm... tested this on my own and... uhhh... why exactly is this not escaped?

(search HTML)

image

(original file)

image

This can be seen pretty clerarly by XML tags being encoded as they are.

image

@lunny This is pretty critical because it's XSS. Please add to 1.4.0 and kind/security.

@thehowl commented on GitHub (Jan 16, 2018): Hmmm... tested this on my own and... uhhh... why exactly is this not escaped? (search HTML) ![image](https://user-images.githubusercontent.com/4681308/34994986-78b7d0f4-fad5-11e7-8ef9-d1aca716ada6.png) (original file) ![image](https://user-images.githubusercontent.com/4681308/34995010-8947550c-fad5-11e7-8689-b3743ca96e67.png) This can be seen pretty clerarly by XML tags being encoded as they are. ![image](https://user-images.githubusercontent.com/4681308/34995070-ba9782c6-fad5-11e7-8180-b8cf4471562b.png) @lunny This is pretty critical because it's XSS. Please add to 1.4.0 and kind/security.
GiteaMirror commented 2025-11-02 04:01:37 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 17, 2018):

Thank you @thehowl , so, it's only needed to escape some additional strings to view the file text context, right?

@ghost commented on GitHub (Jan 17, 2018): Thank you @thehowl , so, it's only needed to escape some additional strings to view the file text context, right?
GiteaMirror commented 2025-11-02 04:01:37 -06:00
Author
Owner
Copy Link

@thehowl commented on GitHub (Jan 17, 2018):

Yes, that's right.

@thehowl commented on GitHub (Jan 17, 2018): Yes, that's right.
GiteaMirror commented 2025-11-02 04:01:37 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 22, 2018):

Thank you very much guys. I will test that PR on master release as soon as drone will be able to build/release it

@ghost commented on GitHub (Jan 22, 2018): Thank you very much guys. I will test that PR on master release as soon as drone will be able to build/release it
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/security type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1461
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?