github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Inconsistent commit signature color in Gitea v1.24 nightly #14563

New Issue
Closed
opened 2025-11-02 11:16:20 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-02 11:16:20 -06:00
Owner
Copy Link

Originally created by @noticebrick on GitHub (Jun 7, 2025).

Description

It appears that the method for obtaining avatar and signature status differs between the commit list and commit info. The primary cause of this issue is that the Git email does not match the gpg key's email, yet the behavior remains inconsistent across the two pages. Please feel free to comment if you need any further information.

Gitea Version

v1.24.0+rc0-51-g8defca6d39

Can you reproduce the bug on the Gitea demo site?

Yes

https://github.com/go-gitea/gitea/issues/34641#issuecomment-2952599068

https://demo.gitea.com/noticebrick/gitea/commits/branch/main

Image

Image

Originally created by @noticebrick on GitHub (Jun 7, 2025). ### Description It appears that the method for obtaining avatar and signature status differs between the commit list and commit info. The primary cause of this issue is that the Git email does not match the gpg key's email, yet the behavior remains inconsistent across the two pages. Please feel free to comment if you need any further information. ### Gitea Version v1.24.0+rc0-51-g8defca6d39 ### Can you reproduce the bug on the Gitea demo site? Yes https://github.com/go-gitea/gitea/issues/34641#issuecomment-2952599068 https://demo.gitea.com/noticebrick/gitea/commits/branch/main ![Image](https://github.com/user-attachments/assets/7ffffb73-cb5c-43ad-ad21-88aeebbc50ff) ![Image](https://github.com/user-attachments/assets/5f0f2ee1-d48d-4e2e-9e18-948216446ae1)
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 11:16:20 -06:00
GiteaMirror commented 2025-11-02 11:16:22 -06:00
Author
Owner
Copy Link

@noticebrick commented on GitHub (Jun 7, 2025):

I forgot to mention that the avatar is also not being resolved correctly.

@noticebrick commented on GitHub (Jun 7, 2025): I forgot to mention that the avatar is also not being resolved correctly.
GiteaMirror commented 2025-11-02 11:16:22 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jun 7, 2025):

What's the commit's email? What's your Gitea user's email?

@wxiaoguang commented on GitHub (Jun 7, 2025): What's the commit's email? What's your Gitea user's email?
GiteaMirror commented 2025-11-02 11:16:22 -06:00
Author
Owner
Copy Link

@noticebrick commented on GitHub (Jun 7, 2025):

I am currently replicating the issue in gitea demo site, please give me some time.

@noticebrick commented on GitHub (Jun 7, 2025): I am currently replicating the issue in gitea demo site, please give me some time.
GiteaMirror commented 2025-11-02 11:16:22 -06:00
Author
Owner
Copy Link

@noticebrick commented on GitHub (Jun 7, 2025):

What's the commit's email? What's your Gitea user's email?

https://demo.gitea.com/noticebrick/gitea
Commit email of "correct email": icebrick0312@gmail.com
Commit email of "wrong email": icebrick@light.tw
GPG Key Email: icebrick0312@gmail.com

Both emails have been added to Gitea user account while gmail.com is primary.

@noticebrick commented on GitHub (Jun 7, 2025): > What's the commit's email? What's your Gitea user's email? https://demo.gitea.com/noticebrick/gitea Commit email of "correct email": icebrick0312@gmail.com Commit email of "wrong email": icebrick@light.tw GPG Key Email: icebrick0312@gmail.com Both emails have been added to Gitea user account while gmail.com is primary.
GiteaMirror commented 2025-11-02 11:16:23 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jun 7, 2025):

Hmm, I think it's caused by the different "querying user's email" approaches (need to figure out the real problem) .....

@wxiaoguang commented on GitHub (Jun 7, 2025): Hmm, I think it's caused by ~~the different "querying user's email" approaches~~ (need to figure out the real problem) .....
GiteaMirror commented 2025-11-02 11:16:23 -06:00
Author
Owner
Copy Link

@noticebrick commented on GitHub (Jun 7, 2025):

By the way, the reason I commented under that issue is that their description somewhat matches the problem I am facing (different commit signature color and avatar), but the fix did not resolve my issue.

@noticebrick commented on GitHub (Jun 7, 2025): By the way, the reason I commented under that issue is that their description somewhat matches the problem I am facing (different commit signature color and avatar), but the fix did not resolve my issue.
GiteaMirror commented 2025-11-02 11:16:23 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jun 7, 2025):

Maybe it is another regression from Improve commits list performance to reduce unnecessary database queries (#33528)

At least, the new code seems wrong, why checking c.Committer != nil since has been used above? @lunny

		committer, ok := emailUsers[c.Committer.Email]
		if !ok && c.Committer != nil {
@wxiaoguang commented on GitHub (Jun 7, 2025): Maybe it is another regression from Improve commits list performance to reduce unnecessary database queries (#33528) At least, the new code seems wrong, why checking `c.Committer != nil` since has been used above? @lunny ``` committer, ok := emailUsers[c.Committer.Email] if !ok && c.Committer != nil { ```
GiteaMirror commented 2025-11-02 11:16:23 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jun 7, 2025):

Thank you for the detailed report. I think we can completely fix the problem by Fix GetUsersByEmails #34643

I tested your commits with your public gpg key:

Image

@wxiaoguang commented on GitHub (Jun 7, 2025): Thank you for the detailed report. I think we can completely fix the problem by Fix GetUsersByEmails #34643 I tested your commits with your public gpg key: ![Image](https://github.com/user-attachments/assets/7e92aee5-0567-4e82-ae2c-0a0c13f32e0f)
GiteaMirror commented 2025-11-02 11:16:24 -06:00
Author
Owner
Copy Link

@noticebrick commented on GitHub (Jun 8, 2025):

Tested on the latest v1.24 nightly and the issue is fixed, thank you!

@noticebrick commented on GitHub (Jun 8, 2025): Tested on the latest v1.24 nightly and the issue is fixed, thank you!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14563
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?