github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Gitea not verifying commit signature #14523

New Issue
Closed
opened 2025-11-02 11:15:13 -06:00 by GiteaMirror · 12 comments
GiteaMirror commented 2025-11-02 11:15:13 -06:00
Owner
Copy Link

Originally created by @lmtr0 on GitHub (May 23, 2025).

Description

Hey there, good day!

Recently I started using GitButler as my main git client, however gitea can't verify it's signatures on the platform (See screenshots bellow). Locally with git everything works, and I verified my key and email in the ui.

Gitea Version

1.23.8

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Here is a screenshot of the commit.

Image

However, a git commit works:

Image

Locally with the Git CLI, all the signatures work fine:

Image

I spoke with the GitButtler team and they said:

Image

Git Version

GitButler latest

Operating System

Linux

How are you running Gitea?

Inside a docker environment on a private cloud with default configuration

Database

None

Originally created by @lmtr0 on GitHub (May 23, 2025). ### Description Hey there, good day! Recently I started using GitButler as my main git client, however gitea can't verify it's signatures on the platform (See screenshots bellow). Locally with git everything works, and I verified my key and email in the ui. ### Gitea Version 1.23.8 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots Here is a screenshot of the commit. ![Image](https://github.com/user-attachments/assets/9e2a1c38-fa81-4ff3-9cec-b597a9646255) However, a git commit works: ![Image](https://github.com/user-attachments/assets/acfa177d-f04f-45a3-8ade-10299c8ff747) Locally with the Git CLI, all the signatures work fine: ![Image](https://github.com/user-attachments/assets/97c239a7-77ae-4fb0-92cb-37a5a267d6ae) I spoke with the GitButtler team and they said: ![Image](https://github.com/user-attachments/assets/47dc3086-d458-4fef-b3b0-6902be3514a9) ### Git Version GitButler latest ### Operating System Linux ### How are you running Gitea? Inside a docker environment on a private cloud with default configuration ### Database None
GiteaMirror added the type/bug label 2025-11-02 11:15:13 -06:00
GiteaMirror commented 2025-11-02 11:15:14 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (May 23, 2025):

Are you able to provide a .patch file of an example commit?

@techknowlogick commented on GitHub (May 23, 2025): Are you able to provide a .patch file of an example commit?
GiteaMirror commented 2025-11-02 11:15:15 -06:00
Author
Owner
Copy Link

@lmtr0 commented on GitHub (May 23, 2025):

Hello @techknowlogick,

I couldn't get the signature to be outputed after 20 min so I gave up.
In https://gist.github.com/lmtr0/4ddc84e9f19f885a58315d3b5c1bd7c3 you will find:

  • example.patch from git show <commit from gitbutler> > example.patch
  • example-show-signature.patch from git show --show-signature <same commit as above> > example-show-signature.patch

However, if you provide me with the command that will show you the information you want I would be happy to provide the output

@lmtr0 commented on GitHub (May 23, 2025): Hello @techknowlogick, I couldn't get the signature to be outputed after 20 min so I gave up. In https://gist.github.com/lmtr0/4ddc84e9f19f885a58315d3b5c1bd7c3 you will find: * example.patch from `git show <commit from gitbutler> > example.patch` * example-show-signature.patch from `git show --show-signature <same commit as above> > example-show-signature.patch` However, if you provide me with the command that will show you the information you want I would be happy to provide the output
GiteaMirror commented 2025-11-02 11:15:15 -06:00
Author
Owner
Copy Link

@Byron commented on GitHub (May 26, 2025):

Here is the git cat-file …| pbcopy output of a signed commit created by GitButler, maybe it's useful.

tree a29321bf9e3ec433ed9e47b1cbbac6906c71fc60
parent c0d83043ade7fa3ca10659608799477e9daa670b
author Sebastian Thiel <sebastian.thiel@icloud.com> 1747920681 +0200
committer Sebastian Thiel <sebastian.thiel@icloud.com> 1748010747 +0200
gitbutler-headers-version 2
gitbutler-change-id 1063f7ea-d841-43b3-903a-01747681c40d
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEE6vnM/NCHZAjyl8YKnLXueJXoJosFAmgwhvsACgkQnLXueJXo
 JovXUxAAq0WKJILCUAxyhwh5tRdxJTB2NjiCLf+ggLfjyrWPtMWPi/YUt7iGPB2H
 Wbv9U7l5t+54fPX8TQtBKZ79YaDMfYdjlfDSijmPruf8/MXB4G0rAaIajtCr0usZ
 kJDOgmmYS7bVMybDe6guwFZappiuSS2dCEYgeJun+q7Y6IYsfvdAluJmGubQIkPT
 rrEffqoQz3URmDYnAKW3sTRUVwCkYIJDxpl/W0Rvc0jmELdkHu7JYX7XvZBYSUDq
 FWgzCPjyErtkKk8AqoeWtTCpL+9ozzNIXNRKjGCOL2LG4H/uuNFdM46HB+KW/7+B
 wMGcpZk8T/zN9Cf348M+y+o09QX1OWavDS6LgvWJaDtG/swgxV96KKR5lEtdd1IU
 JHuXfPUfGp4r378FIrbPK+Thu5bn9Yq8qGvdZOpTqDxHPU9/o9wLpJghcWJZ5O3X
 MpK4HdN+bME2zgBd08QsOjANogbJIz9MVaMGRFlCO5iOiz2DxG+v2KkO8IRwGXaO
 OKKQ7BD04fS2wFma862BaTtB9M9f9UTWV4e2mgRpSDJWTQKrj+HkJ63gAFQYFnfp
 ppgqZLkmzH1Ta2U56JSMMfOoKVFgjuxRx1d+tzdC+TpQyo06NI1KkNMepK1rhFBW
 p8hej6n/7Bl9LL/W+DKsNqW9jQbTYu66JqKs3Kg7xga6w/ss0iw=
 =VG6I
 -----END PGP SIGNATURE-----

asdf
asdf
asdf
@Byron commented on GitHub (May 26, 2025): Here is the `git cat-file …| pbcopy` output of a signed commit created by GitButler, maybe it's useful. ``` tree a29321bf9e3ec433ed9e47b1cbbac6906c71fc60 parent c0d83043ade7fa3ca10659608799477e9daa670b author Sebastian Thiel <sebastian.thiel@icloud.com> 1747920681 +0200 committer Sebastian Thiel <sebastian.thiel@icloud.com> 1748010747 +0200 gitbutler-headers-version 2 gitbutler-change-id 1063f7ea-d841-43b3-903a-01747681c40d gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE6vnM/NCHZAjyl8YKnLXueJXoJosFAmgwhvsACgkQnLXueJXo JovXUxAAq0WKJILCUAxyhwh5tRdxJTB2NjiCLf+ggLfjyrWPtMWPi/YUt7iGPB2H Wbv9U7l5t+54fPX8TQtBKZ79YaDMfYdjlfDSijmPruf8/MXB4G0rAaIajtCr0usZ kJDOgmmYS7bVMybDe6guwFZappiuSS2dCEYgeJun+q7Y6IYsfvdAluJmGubQIkPT rrEffqoQz3URmDYnAKW3sTRUVwCkYIJDxpl/W0Rvc0jmELdkHu7JYX7XvZBYSUDq FWgzCPjyErtkKk8AqoeWtTCpL+9ozzNIXNRKjGCOL2LG4H/uuNFdM46HB+KW/7+B wMGcpZk8T/zN9Cf348M+y+o09QX1OWavDS6LgvWJaDtG/swgxV96KKR5lEtdd1IU JHuXfPUfGp4r378FIrbPK+Thu5bn9Yq8qGvdZOpTqDxHPU9/o9wLpJghcWJZ5O3X MpK4HdN+bME2zgBd08QsOjANogbJIz9MVaMGRFlCO5iOiz2DxG+v2KkO8IRwGXaO OKKQ7BD04fS2wFma862BaTtB9M9f9UTWV4e2mgRpSDJWTQKrj+HkJ63gAFQYFnfp ppgqZLkmzH1Ta2U56JSMMfOoKVFgjuxRx1d+tzdC+TpQyo06NI1KkNMepK1rhFBW p8hej6n/7Bl9LL/W+DKsNqW9jQbTYu66JqKs3Kg7xga6w/ss0iw= =VG6I -----END PGP SIGNATURE----- asdf asdf asdf ```
GiteaMirror commented 2025-11-02 11:15:15 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 27, 2025):

-> Refactor commit reader #34542

@wxiaoguang commented on GitHub (May 27, 2025): -> Refactor commit reader #34542
GiteaMirror commented 2025-11-02 11:15:15 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 27, 2025):

The fix is in main branch now. It will be backported to 1.24

@wxiaoguang commented on GitHub (May 27, 2025): The fix is in main branch now. It will be backported to 1.24
GiteaMirror commented 2025-11-02 11:15:15 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 27, 2025):

You can try 1.24-nightly now (it will be 1.24.0 soon and contains the fix)

@wxiaoguang commented on GitHub (May 27, 2025): You can try 1.24-nightly now (it will be 1.24.0 soon and contains the fix) * https://dl.gitea.com/gitea/1.24-nightly/ * https://hub.docker.com/r/gitea/gitea/tags?name=1.24-nightly
GiteaMirror commented 2025-11-02 11:15:15 -06:00
Author
Owner
Copy Link

@lmtr0 commented on GitHub (May 27, 2025):

Thank you, @wxiaoguang, for the quick response, implementation and now release, and thanks to @Byron for the helpful resources.

As soon as the fix gets to stable I will check it out

@lmtr0 commented on GitHub (May 27, 2025): Thank you, @wxiaoguang, for the quick response, implementation and now release, and thanks to @Byron for the helpful resources. As soon as the fix gets to stable I will check it out
GiteaMirror commented 2025-11-02 11:15:15 -06:00
Author
Owner
Copy Link

@lmtr0 commented on GitHub (May 29, 2025):

@wxiaoguang do we have any time expectations to when this will be live? As in, in the latest docker image.

@lmtr0 commented on GitHub (May 29, 2025): @wxiaoguang do we have any time expectations to when this will be live? As in, in the latest docker image.
GiteaMirror commented 2025-11-02 11:15:16 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 29, 2025):

You can try 1.24-nightly now (it will be 1.24.0 soon and contains the fix)

It it almost the same as the the new 1.24 latest (which will be there in some days)

@wxiaoguang commented on GitHub (May 29, 2025): You can try 1.24-nightly now (it will be 1.24.0 soon and contains the fix) * https://hub.docker.com/r/gitea/gitea/tags?name=1.24-nightly It it almost the same as the the new 1.24 latest (which will be there in some days)
GiteaMirror commented 2025-11-02 11:15:16 -06:00
Author
Owner
Copy Link

@lmtr0 commented on GitHub (May 29, 2025):

thx

@lmtr0 commented on GitHub (May 29, 2025): thx
GiteaMirror commented 2025-11-02 11:15:16 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (May 29, 2025):

The nightly builds of the versioned releases are all considered to be "stable" enough and will become the next versioned release.

If you'd like to follow 1.24 release, here is the PR:

@wxiaoguang commented on GitHub (May 29, 2025): The nightly builds of the versioned releases are all considered to be "stable" enough and will become the next versioned release. If you'd like to follow 1.24 release, here is the PR: * https://github.com/go-gitea/gitea/pull/34543
GiteaMirror commented 2025-11-02 11:15:16 -06:00
Author
Owner
Copy Link

@lmtr0 commented on GitHub (Jun 10, 2025):

Image

would you look at that :)

Thanks @wxiaoguang for the help

@lmtr0 commented on GitHub (Jun 10, 2025): ![Image](https://github.com/user-attachments/assets/ded5a267-e223-4f8c-80b0-3851a4d6e8a9) would you look at that :) Thanks @wxiaoguang for the help
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?