Cannot request changes on own PR #14499

New Issue

GiteaMirror · 2025-11-02T11:14:36-06:00

GiteaMirror commented

2025-11-02 11:14:36 -06:00

Originally created by @ascendise on GitHub (May 15, 2025).

Description

I tried to create a review on my own PR, so it blocks the PR from merging before issues are resolved.
I noticed that I wasn't able to add myself as a reviewer, but I was able to go to the file changes and add comments to lines and start a review.

When I tried to submit the review, "Approve" and "Request Changes" were greyed out and not clickable. Hovering over it tells me, that I am not able to review my own PR. I can comment my review and it added all the things I noticed to the issue, but it does not block the PR from getting merged. (I have set a branch protection rule with "Block merge on rejected reviews")

https://github.com/go-gitea/gitea/issues/7289

This old issue was closed, because it seemed like it worked and was just a visual issue (I wasn't able to click the button)
I did try to just enable the button with some "Inspect Element"-magic and click it that way, but was greeted with this error and my PR still mergable.

I am not sure if this is just not supported, but that would be a bummer, as I don't see any harm in being able to review yourself

Gitea Version

1.23.8

Can you reproduce the bug on the Gitea demo site?

Did not try there, yet

Log Gist

No response

Screenshots

No response

Git Version

2.47.2

Operating System

Alpine 3.21.3

How are you running Gitea?

Deployed with docker

Database

SQLite

Originally created by @ascendise on GitHub (May 15, 2025). ### Description I tried to create a review on my own PR, so it blocks the PR from merging before issues are resolved. I noticed that I wasn't able to add myself as a reviewer, but I was able to go to the file changes and add comments to lines and start a review. When I tried to submit the review, "Approve" and "Request Changes" were greyed out and not clickable. Hovering over it tells me, that I am not able to review my own PR. I can comment my review and it added all the things I noticed to the issue, but it does not block the PR from getting merged. (I have set a branch protection rule with "Block merge on rejected reviews") ![Image](https://github.com/user-attachments/assets/13ba0f03-0016-43f2-b70a-370de72eb4a6) https://github.com/go-gitea/gitea/issues/7289 This old issue was closed, because it seemed like it worked and was just a visual issue (I wasn't able to click the button) I did try to just enable the button with some "Inspect Element"-magic and click it that way, but was greeted with this error and my PR still mergable. ![Image](https://github.com/user-attachments/assets/e14e3c1b-6b97-4b58-b67d-b78dc3dbacbd) I am not sure if this is just not supported, but that would be a bummer, as I don't see any harm in being able to review yourself ### Gitea Version 1.23.8 ### Can you reproduce the bug on the Gitea demo site? Did not try there, yet ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version 2.47.2 ### Operating System Alpine 3.21.3 ### How are you running Gitea? Deployed with [docker](https://hub.docker.com/layers/gitea/gitea/latest/images/sha256-736ff5a698bbcabe33315adaa4d06571ab5f2dc2b5cd6c85b64ed4fd9ce2b6ac) ### Database SQLite

GiteaMirror added the issue/not-a-bug label 2025-11-02 11:14:36 -06:00

GiteaMirror commented

2025-11-02 11:14:36 -06:00

@lunny commented on GitHub (May 15, 2025):

I think this is by design. Otherwise it will bypass the protected branch rules.

@lunny commented on GitHub (May 15, 2025): I think this is by design. Otherwise it will bypass the protected branch rules.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#14499