ESLint config + build fail if PR code does not follow the config #1442

New Issue

GiteaMirror · 2025-11-02T04:00:59-06:00

GiteaMirror commented

2025-11-02 04:00:59 -06:00

Originally created by @thehowl on GitHub (Jan 11, 2018).

In an attempt to have JavaScript code that is not an unmanageable mess where there are even mixed " and ' for string literals, I would propose to add an eslint config to gitea; public/js/* would then be checked for errors by the CI, to ensure that we have a consistent style in the JavaScript code.

Originally created by @thehowl on GitHub (Jan 11, 2018). In an attempt to have JavaScript code that is not an unmanageable mess where there are even mixed `"` and `'` for string literals, I would propose to add an [eslint](https://eslint.org/) config to gitea; public/js/* would then be checked for errors by the CI, to ensure that we have a consistent style in the JavaScript code.

GiteaMirror added the type/proposal label 2025-11-02 04:00:59 -06:00

GiteaMirror closed this issue

2025-11-02 04:01:00 -06:00

GiteaMirror commented

2025-11-02 04:01:00 -06:00

@lafriks commented on GitHub (Jan 11, 2018):

With prettier.io ;)

@lafriks commented on GitHub (Jan 11, 2018): With prettier.io ;)

GiteaMirror commented

2025-11-02 04:01:00 -06:00

@silverwind commented on GitHub (Jan 11, 2018):

Sounds good. You can add the eslint dependency to package.json, just need to make sure npm install runs before testing.

@silverwind commented on GitHub (Jan 11, 2018): Sounds good. You can add the `eslint` dependency to [`package.json`](https://github.com/go-gitea/gitea/blob/master/package.json), just need to make sure `npm install` runs before testing.

GiteaMirror commented

2025-11-02 04:01:00 -06:00

@sapk commented on GitHub (Jan 16, 2020):

I think it is done now (https://github.com/go-gitea/gitea/blob/master/.eslintrc).
If I am mistaken feel free to re-open.

@sapk commented on GitHub (Jan 16, 2020): I think it is done now (https://github.com/go-gitea/gitea/blob/master/.eslintrc). If I am mistaken feel free to re-open.

GiteaMirror commented

2025-11-02 04:01:00 -06:00

@silverwind commented on GitHub (Jan 16, 2020):

Yes it is. make build will fail on ESLint errors.

@silverwind commented on GitHub (Jan 16, 2020): Yes it is. `make build` will fail on ESLint errors.

GiteaMirror referenced this issue

2025-11-02 11:57:30 -06:00

[PR #1444] [MERGED] Optimize and fix autolink function (#1442) #15907

Sign in to join this conversation.