Avatars uploaded to instance are not cached #1430

New Issue

GiteaMirror · 2025-11-02T04:00:31-06:00

GiteaMirror commented

2025-11-02 04:00:31 -06:00

Originally created by @thehowl on GitHub (Jan 7, 2018).

Example when loading my try.gitea.io dashboard:

This leads to some pretty poor performance when loading the page. On multiple retries, avatars served from try.gitea.io directly are never cached - which is pretty bad. This seems to be an issue with macaron's static file server itself, since as far as I can tell it never e.g. checks for the ETag on the request - only sends it. There is also no Expires header, which would be pretty nice to set for at least some time (e.g. an hour).

The best way to go here to me seems to copy the static file serving function and suit it to Gitea's needs altogether - seeing as I doubt unknwon will merge PRs to macaron (due to his current inactivity)

Originally created by @thehowl on GitHub (Jan 7, 2018). Example when loading my try.gitea.io dashboard: ![image](https://user-images.githubusercontent.com/4681308/34651114-efcc659e-f3cb-11e7-9808-79565708038f.png) This leads to some pretty poor performance when loading the page. On multiple retries, avatars served from try.gitea.io directly are never cached - which is pretty bad. This seems to be an issue with macaron's static file server itself, since as far as I can tell it never e.g. checks for the ETag on the request - only sends it. There is also no Expires header, which would be pretty nice to set for at least some time (e.g. an hour). The best way to go here to me seems to copy the static file serving function and suit it to Gitea's needs altogether - seeing as I doubt unknwon will merge PRs to macaron (due to his current inactivity)

GiteaMirror added the type/enhancement label 2025-11-02 04:00:31 -06:00

GiteaMirror closed this issue

2025-11-02 04:00:31 -06:00

GiteaMirror commented

2025-11-02 04:00:32 -06:00

@ethantkoenig commented on GitHub (Jan 19, 2018):

FWIW, I have succeeded in making contribution to unknwon's repos in the past (https://github.com/go-macaron/macaron/pull/149, https://github.com/go-ini/ini/pull/115). Even if in the short-term we have to make the change to gitea, I do think we should ultimately try to add caching to macaron (which is where it really belongs)

@ethantkoenig commented on GitHub (Jan 19, 2018): FWIW, I have succeeded in making contribution to unknwon's repos in the past (https://github.com/go-macaron/macaron/pull/149, https://github.com/go-ini/ini/pull/115). Even if in the short-term we have to make the change to gitea, I do think we should ultimately try to add caching to macaron (which is where it really belongs)

GiteaMirror commented

2025-11-02 04:00:32 -06:00

@thehowl commented on GitHub (Jan 20, 2018):

Fair enough. I've created an issue for it on the macaron repository: https://github.com/go-macaron/macaron/issues/152 should the owner come back, I'll be very glad to port over the feature there.

@thehowl commented on GitHub (Jan 20, 2018): Fair enough. I've created an issue for it on the macaron repository: https://github.com/go-macaron/macaron/issues/152 should the owner come back, I'll be very glad to port over the feature there.

GiteaMirror referenced this issue

2025-11-02 11:57:25 -06:00

[PR #1438] [MERGED] Add GOFLAGS and EXTRA_GOFLAGS #15904

GiteaMirror referenced this issue

2025-11-02 11:57:28 -06:00

[PR #1441] [MERGED] Enable race detector for CI #15906

Sign in to join this conversation.