github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-10 15:39:40 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Broken parsing of Rust multiline Attribute Macros #14263

New Issue
Closed
opened 2025-11-02 11:07:56 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 11:07:56 -06:00
Owner
Copy Link

Originally created by @vpochapuis on GitHub (Mar 17, 2025).

Description

Issue encountered

While doing PR reviews I stumbled upon this bug in the Files Changed tab:

Image

The Attribute Macro (in Rust) which is spread over 2 lines is having the second line string text not being displayed in the same color as the previous part of the same string.

Why would we like to fix it

It seems it would be intended to have the same color for the same string in that Attribute Macro.

In Zed editor:

Image

In VsCodium IDE:

Image

System Info

OS: Debian
Gitea version: 1.23.5

Thank you for your time reading this~

Gitea Version

1.23.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Self-Hosted Debian based LXC using APT repository.

Database

None

Originally created by @vpochapuis on GitHub (Mar 17, 2025). ### Description # Issue encountered While doing PR reviews I stumbled upon this bug in the `Files Changed` tab: ![Image](https://github.com/user-attachments/assets/04ac1ab6-7851-4c5a-8ac0-a41425db3750) The Attribute Macro (in Rust) which is spread over 2 lines is having the second line string text not being displayed in the same color as the previous part of the same string. # Why would we like to fix it It seems it would be intended to have the same color for the same string in that Attribute Macro. In Zed editor: ![Image](https://github.com/user-attachments/assets/d73b7fb2-81ea-4155-a12c-a4235610f799) In VsCodium IDE: ![Image](https://github.com/user-attachments/assets/4271696c-6292-4af8-9529-f6b3a9580732) # System Info OS: Debian Gitea version: 1.23.5 Thank you for your time reading this~ ### Gitea Version 1.23.5 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Self-Hosted Debian based LXC using APT repository. ### Database None
GiteaMirror added the issue/needs-feedback label 2025-11-02 11:07:56 -06:00
GiteaMirror commented 2025-11-02 11:07:57 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 17, 2025):

I think it should have been fixed by Full-file syntax highlighting for diff pages #33766 in 1.24 (which is main-nightly at the moment).

@wxiaoguang commented on GitHub (Mar 17, 2025): I think it should have been fixed by Full-file syntax highlighting for diff pages #33766 in 1.24 (which is main-nightly at the moment).
GiteaMirror commented 2025-11-02 11:07:57 -06:00
Author
Owner
Copy Link

@vpochapuis commented on GitHub (Mar 17, 2025):

I think it should have been fixed by Full-file syntax highlighting for diff pages #33766 in 1.24 (which is main-nightly at the moment).

Ok great! Thanks for the fast answer!
Should we close this one? Can someone confirm this on 1.24?

@vpochapuis commented on GitHub (Mar 17, 2025): > I think it should have been fixed by Full-file syntax highlighting for diff pages [#33766](https://github.com/go-gitea/gitea/pull/33766) in 1.24 (which is main-nightly at the moment). Ok great! Thanks for the fast answer! Should we close this one? Can someone confirm this on 1.24?
GiteaMirror commented 2025-11-02 11:07:57 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 17, 2025):

Demo site: https://demo.gitea.com/wxiaoguang/test-repo/pulls/3/files

And you could also deploy the main-nightly build https://dl.gitea.com/gitea/main-nightly/ in your environment, it should be stable enough for daily usage.

@wxiaoguang commented on GitHub (Mar 17, 2025): Demo site: https://demo.gitea.com/wxiaoguang/test-repo/pulls/3/files And you could also deploy the main-nightly build https://dl.gitea.com/gitea/main-nightly/ in your environment, it should be stable enough for daily usage.
GiteaMirror commented 2025-11-02 11:07:57 -06:00
Author
Owner
Copy Link

@vpochapuis commented on GitHub (Mar 17, 2025):

Demo site: https://demo.gitea.com/wxiaoguang/test-repo/pulls/3/files

And you could also deploy the main-nightly build https://dl.gitea.com/gitea/main-nightly/ in your environment, it should be stable enough for daily usage.

Ok great seems fixed! Thanks a lot for the help and the check!
I can close this then.

Thanks for the information about nightly builds, i will evaluate whether to switch or not!
Have a nice day~

@vpochapuis commented on GitHub (Mar 17, 2025): > Demo site: https://demo.gitea.com/wxiaoguang/test-repo/pulls/3/files > > And you could also deploy the main-nightly build https://dl.gitea.com/gitea/main-nightly/ in your environment, it should be stable enough for daily usage. Ok great seems fixed! Thanks a lot for the help and the check! I can close this then. Thanks for the information about nightly builds, i will evaluate whether to switch or not! Have a nice day~
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/needs-feedback
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?