Code search exact makes not exact search #14186

Closed
opened 2025-11-02 11:05:40 -06:00 by GiteaMirror · 6 comments
Owner

Originally created by @gomanuke on GitHub (Feb 25, 2025).

Description

Here You are a file that returns by "GetPrev" search string.
IMHO exact searching must not return it.

prompt --application/shared_components/user_interface/shortcuts/ok_to_get_next_prev_pk_value begin -- Manifest -- SHORTCUT: OK_TO_GET_NEXT_PREV_PK_VALUE -- Manifest End wwv_flow_imp.component_begin ( p_version_yyyy_mm_dd=>'2024.05.31' ,p_release=>'24.1.7' ,p_default_workspace_id=>1202104075024633 ,p_default_application_id=>401 ,p_default_id_offset=>8704503425691951 ,p_default_owner=>'OBLAKO_PRINT' ); wwv_flow_imp_shared.create_shortcut( p_id=>wwv_flow_imp.id(26669283042465176847) ,p_shortcut_name=>'OK_TO_GET_NEXT_PREV_PK_VALUE' ,p_shortcut_type=>'TEXT_ESCAPE_JS' ,p_version_scn=>1 ,p_shortcut=>'Are you sure you want to leave this page without saving?' ); wwv_flow_imp.component_end; end; /

Gitea Version

1.23.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian 12

How are you running Gitea?

systemctl daemon

Database

MySQL/MariaDB

Originally created by @gomanuke on GitHub (Feb 25, 2025). ### Description Here You are a file that returns by "GetPrev" search string. IMHO exact searching must not return it. `prompt --application/shared_components/user_interface/shortcuts/ok_to_get_next_prev_pk_value begin -- Manifest -- SHORTCUT: OK_TO_GET_NEXT_PREV_PK_VALUE -- Manifest End wwv_flow_imp.component_begin ( p_version_yyyy_mm_dd=>'2024.05.31' ,p_release=>'24.1.7' ,p_default_workspace_id=>1202104075024633 ,p_default_application_id=>401 ,p_default_id_offset=>8704503425691951 ,p_default_owner=>'OBLAKO_PRINT' ); wwv_flow_imp_shared.create_shortcut( p_id=>wwv_flow_imp.id(26669283042465176847) ,p_shortcut_name=>'OK_TO_GET_NEXT_PREV_PK_VALUE' ,p_shortcut_type=>'TEXT_ESCAPE_JS' ,p_version_scn=>1 ,p_shortcut=>'Are you sure you want to leave this page without saving?' ); wwv_flow_imp.component_end; end; / ` ### Gitea Version 1.23.4 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System Debian 12 ### How are you running Gitea? systemctl daemon ### Database MySQL/MariaDB
GiteaMirror added the type/bug label 2025-11-02 11:05:40 -06:00
Author
Owner

@wxiaoguang commented on GitHub (Feb 25, 2025):

@6543 need to remove the "fuzzy"?

@wxiaoguang commented on GitHub (Feb 25, 2025): @6543 need to remove the "fuzzy"?
Author
Owner

@gomanuke commented on GitHub (Feb 25, 2025):

Exact is by default:

Image

@gomanuke commented on GitHub (Feb 25, 2025): Exact is by default: ![Image](https://github.com/user-attachments/assets/08c8947d-4239-4b4e-acd2-f3af7fb4bc94)
Author
Owner

@jpraet commented on GitHub (Feb 25, 2025):

Possibly resolved by #33628 which restores the search mode for bleve from MatchQuery back to MatchPhraseQuery, as it was in 1.22.

On the main branch though, it is still using MatchQuery, but with #33590 a "literal search mode" was added (by using quotes).

@jpraet commented on GitHub (Feb 25, 2025): Possibly resolved by #33628 which restores the search mode for bleve from MatchQuery back to MatchPhraseQuery, as it was in 1.22. On the main branch though, it is still using MatchQuery, but with #33590 a "literal search mode" was added (by using quotes).
Author
Owner

@gomanuke commented on GitHub (Feb 26, 2025):

Appreciate You for explanation. Using quotes is definitely solution.
Would You clarify about release practice: when we can get binary with #33590 ?

@gomanuke commented on GitHub (Feb 26, 2025): Appreciate You for explanation. Using quotes is definitely solution. Would You clarify about release practice: when we can get binary with #33590 ?
Author
Owner

@lunny commented on GitHub (Feb 26, 2025):

#33628 will be released in v1.23.5 and #33590 will be released in v1.24.0 .

@lunny commented on GitHub (Feb 26, 2025): #33628 will be released in v1.23.5 and #33590 will be released in v1.24.0 .
Author
Owner

@lunny commented on GitHub (Feb 26, 2025):

I think we can close this at the moment since two PRs are merged.

@lunny commented on GitHub (Feb 26, 2025): I think we can close this at the moment since two PRs are merged.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14186