CODEOWNERS functionality is only triggered when opening a PR, but not after changes #14092

New Issue

GiteaMirror · 2025-11-02T11:02:38-06:00

GiteaMirror commented

2025-11-02 11:02:38 -06:00

Originally created by @Merciful12 on GitHub (Feb 4, 2025).

Description

When a new PR is opened CODEOWNERS functionality is triggered, but afterwards changes in the PR don't trigger CODEOWNERS functionality again.

For example I have next CODEOWNERS:

file1.js @user1
file2.js @user2

If I change file1.js and open a new PR, user1 will be assigned as a reviewer. Then I change file2.js in the same branch so the PR has 2 changed files: file1.js and file2.js but CODEOWNER of file2.js (user2) is not assigned as a reviewer

Gitea Version

1.23.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Not relevant

Database

None

Originally created by @Merciful12 on GitHub (Feb 4, 2025). ### Description When a new PR is opened CODEOWNERS functionality is triggered, but afterwards changes in the PR don't trigger CODEOWNERS functionality again. For example I have next CODEOWNERS: ``` file1.js @user1 file2.js @user2 ``` If I change `file1.js` and open a new PR, `user1` will be assigned as a reviewer. Then I change `file2.js` in the same branch so the PR has 2 changed files: `file1.js` and `file2.js` but CODEOWNER of `file2.js` (`user2`) is not assigned as a reviewer ### Gitea Version 1.23.1 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Not relevant ### Database None

GiteaMirror added the type/bug label 2025-11-02 11:02:38 -06:00

GiteaMirror closed this issue

2025-11-02 11:02:39 -06:00

GiteaMirror commented

2025-11-02 11:02:40 -06:00

@jpraet commented on GitHub (Feb 27, 2025):

This feels quite important to fix. CODEOWNERS feature can be used for audits about PR's that touch certain files.
CODEOWNERS reviews not triggering when the file is modified after the creation of the PR definitely does not meet the user expectation.

@jpraet commented on GitHub (Feb 27, 2025): This feels quite important to fix. CODEOWNERS feature can be used for audits about PR's that touch certain files. CODEOWNERS reviews not triggering when the file is modified **after** the creation of the PR definitely does not meet the user expectation.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#14092