github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-21 14:06:26 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Lots of unnecessary/repetitive unlocked icons in commit list #14043

New Issue
Closed
opened 2025-11-02 11:01:07 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 11:01:07 -06:00
Owner
Copy Link

Originally created by @ghost on GitHub (Jan 25, 2025).

Description

Too many unlocked icon in commit list, especially for unsigned commits, simply no need of an "unverified" icon, unless adding vigilant mode as what GitHub does. (example on demo site: https://demo.gitea.com/lunny/TheSession-data/commits/branch/main)

https://github.com/go-gitea/gitea/pull/10425 looks quite smooth and distinguished.
While changes from https://github.com/go-gitea/gitea/pull/31160 simply determines the icon display by whether commit signed (verified) or not. 079a1ffe8f/templates/repo/commit_sign_badge.tmpl

Screenshots

Image

Image

Gitea Version

7da8a01d

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Firefox 134.0

Originally created by @ghost on GitHub (Jan 25, 2025). ### Description Too many unlocked icon in commit list, especially for unsigned commits, simply no need of an "unverified" icon, unless adding vigilant mode as what GitHub does. (example on demo site: https://demo.gitea.com/lunny/TheSession-data/commits/branch/main) https://github.com/go-gitea/gitea/pull/10425 looks quite smooth and distinguished. While changes from https://github.com/go-gitea/gitea/pull/31160 simply determines the icon display by whether commit signed (verified) or not. https://github.com/go-gitea/gitea/blob/079a1ffe8f38e0c7570079b21a4d8cec4d90e923/templates/repo/commit_sign_badge.tmpl ### Screenshots ![Image](https://github.com/user-attachments/assets/33a9cfb4-3fa3-4282-a72a-5e3f34f0e284) ![Image](https://github.com/user-attachments/assets/b1c38651-a5da-4cc8-ac00-96d5fea122c0) ### Gitea Version 7da8a01d ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System _No response_ ### Browser Version Firefox 134.0
GiteaMirror added the type/bug label 2025-11-02 11:01:07 -06:00
GiteaMirror commented 2025-11-02 11:01:08 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jan 25, 2025):

I think this proposal is acceptable from this side but that's not a bug.

@lunny commented on GitHub (Jan 25, 2025): I think this proposal is acceptable from this side but that's not a bug.
GiteaMirror commented 2025-11-02 11:01:08 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 25, 2025):

I think it is a bug, we should avoid showing unnecessary locks.

@wxiaoguang commented on GitHub (Jan 25, 2025): I think it is a bug, we should avoid showing unnecessary locks.
GiteaMirror commented 2025-11-02 11:01:09 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 25, 2025):

The fix could be like this: Do not show unnecessary commit sign lock icon #33387

@wxiaoguang commented on GitHub (Jan 25, 2025): The fix could be like this: Do not show unnecessary commit sign lock icon #33387
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14043
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?