Flash message cookie is escaped twice #14035

Closed
opened 2025-11-02 11:00:54 -06:00 by GiteaMirror · 3 comments
Owner

Originally created by @Zettat123 on GitHub (Jan 24, 2025).

Description

This issue is from https://github.com/go-gitea/gitea/pull/33298#discussion_r1919570235 . I'm not sure if it's a bug.

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

command

Database

None

Originally created by @Zettat123 on GitHub (Jan 24, 2025). ### Description This issue is from https://github.com/go-gitea/gitea/pull/33298#discussion_r1919570235 . I'm not sure if it's a bug. ### Gitea Version main ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? command ### Database None
GiteaMirror added the issue/needs-feedback label 2025-11-02 11:00:54 -06:00
Author
Owner

@wxiaoguang commented on GitHub (Jan 24, 2025):

I do not think it is a bug.

When using the value, it will also be decoded twice.

@wxiaoguang commented on GitHub (Jan 24, 2025): I do not think it is a bug. When using the value, it will also be decoded twice.
Author
Owner

@Zettat123 commented on GitHub (Jan 24, 2025):

I do not think it is a bug.

When using the value, it will also be decoded twice.

Thanks for your explanation. Looks like the test code was incorrect. I fixed it in #33298 as well.

@Zettat123 commented on GitHub (Jan 24, 2025): > I do not think it is a bug. > > When using the value, it will also be decoded twice. Thanks for your explanation. Looks like the test code was incorrect. I fixed it in #33298 as well.
Author
Owner

@wxiaoguang commented on GitHub (Jan 24, 2025):

Actually, I think you need this: Refactor context flash msg #33375

@wxiaoguang commented on GitHub (Jan 24, 2025): Actually, I think you need this: Refactor context flash msg #33375
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#14035