Gitea submits webhooks on &#34;status&#34; event, even if webhook is defined only for &#34;push&#34; #14006

@lunny commented on GitHub (Jan 16, 2025):

I will investigate it and could you confirm whether you created a webhook with only a push event in Gitea?

@lunny commented on GitHub (Jan 16, 2025): I will investigate it and could you confirm whether you created a webhook with only a push event in Gitea?

GiteaMirror commented

@wolfaba commented on GitHub (Jan 17, 2025):

yes, for Jenkins, we have "Trigger on: Push events", see the attached screenshot

@wolfaba commented on GitHub (Jan 17, 2025): yes, for Jenkins, we have "Trigger on: Push events", see the attached screenshot ![Image](https://github.com/user-attachments/assets/47fe6be8-ea82-4e92-aaa6-c81502810f0a)

GiteaMirror commented

@m-erhardt commented on GitHub (Jan 17, 2025):

I'm affected by this as well. Judging by the JSON payload of the webhook I would guess this relates to Gitea Actions CI jobs...

My webhook is configured to only run on Push events on the master-branch.

The context-element of the JSON request bodys corresponds to the names of my CI jobs in the repo and the description-elements is either Waiting to run or Successful in [x]s

{
  "commit": {
    "id": "411acbb5098d2257592f94bfa1bbf121cb61df78",
    [...]
  },
  "context": "Name of CI job",
  "created_at": "2025-01-17T08:50:30Z",
  "description": "Successful in 1m17s",
  [...]
}

So it seems the webhook gets fired twice per CI job. One with "description": "Waiting to run" and one with "description": "Successful in ...s"

@m-erhardt commented on GitHub (Jan 17, 2025): I'm affected by this as well. Judging by the JSON payload of the webhook I would guess this relates to Gitea Actions CI jobs... My webhook is configured to only run on `Push` events on the `master`-branch. The `context`-element of the JSON request bodys corresponds to the names of my CI jobs in the repo and the `description`-elements is either `Waiting to run` or `Successful in [x]s` ```json { "commit": { "id": "411acbb5098d2257592f94bfa1bbf121cb61df78", [...] }, "context": "Name of CI job", "created_at": "2025-01-17T08:50:30Z", "description": "Successful in 1m17s", [...] } ``` So it seems the webhook gets fired twice per CI job. One with `"description": "Waiting to run"` and one with `"description": "Successful in ...s"`

GiteaMirror commented

2025-11-02 10:59:56 -06:00

@dR3b commented on GitHub (Jan 20, 2025):

I'm affected too. Please backport this fix as soon as possible. Thanks

@dR3b commented on GitHub (Jan 20, 2025): I'm affected too. Please backport this fix as soon as possible. Thanks

GiteaMirror commented

@foxit64 commented on GitHub (Jan 23, 2025):

I have the same problem! Gitea webhooks are send several times.

@foxit64 commented on GitHub (Jan 23, 2025): I have the same problem! Gitea webhooks are send several times.

GiteaMirror commented

2025-11-02 10:59:56 -06:00

@wolfaba commented on GitHub (Jan 23, 2025):

@lunny do you have any time plan for next release with the fix? Thank you.

@wolfaba commented on GitHub (Jan 23, 2025): @lunny do you have any time plan for next release with the fix? Thank you.

GiteaMirror commented

2025-11-02 10:59:56 -06:00

@lunny commented on GitHub (Jan 23, 2025):

@lunny do you have any time plan for next release with the fix? Thank you.

This should be fixed in v1.23.2 I have sent a pull request #33320 and I hope it can be merged ASAP after that is merged I can release v1.23.2. The expectation date is outdated. 😢

@lunny commented on GitHub (Jan 23, 2025): > [<img alt="" width="16" height="16" src="https://avatars.githubusercontent.com/u/81045?s=64&u=99b64f0ca6ef63643c7583ab87dd31c52d28e673&v=4">@lunny](https://github.com/lunny) do you have any time plan for next release with the fix? Thank you. This should be fixed in v1.23.2 I have sent a pull request #33320 and I hope it can be merged ASAP after that is merged I can release v1.23.2. The expectation date is outdated. 😢

GiteaMirror commented

@lunny commented on GitHub (Jan 30, 2025):

I think you can work around this issue by selecting custom events and exclusively choosing the push event at the moment.

@lunny commented on GitHub (Jan 30, 2025): I think you can work around this issue by selecting custom events and exclusively choosing the push event at the moment.

GiteaMirror commented

@wolfaba commented on GitHub (Jan 30, 2025):

I have tried to select only push event and it still runs multiple webhooks.

@wolfaba commented on GitHub (Jan 30, 2025): I have tried to select only push event and it still runs multiple webhooks.

GiteaMirror commented

@lunny commented on GitHub (Feb 3, 2025):

#33442 should have fixed this problem.
#33320 will allow configuration status webhook in settings and fix the correct status webhook content.

@lunny commented on GitHub (Feb 3, 2025): #33442 should have fixed this problem. #33320 will allow configuration status webhook in settings and fix the correct status webhook content.

GiteaMirror commented

@otbutz commented on GitHub (Feb 6, 2025):

@lunny updated from 1.23.1 to 1.23.3 and was hit with a barrage of Commit Status changed webhook notifications:

According to the settings of the webhook, commit status events shouldn't be active:

@otbutz commented on GitHub (Feb 6, 2025): @lunny updated from 1.23.1 to 1.23.3 and was hit with a barrage of `Commit Status changed` webhook notifications: ![Image](https://github.com/user-attachments/assets/c96eebf0-e353-4a6d-81ee-512810b6683a) According to the settings of the webhook, commit status events shouldn't be active: ![Image](https://github.com/user-attachments/assets/deb240a2-05d8-49fe-88c9-c0cab4bdbab8)

GiteaMirror commented

@otbutz commented on GitHub (Feb 6, 2025):

Could this be something persistency related? There hasn't been any event after I edited the webhook settings. (basically a no-op):

Enable Statuses -> Apply -> Disable Statuses -> Apply

@otbutz commented on GitHub (Feb 6, 2025): Could this be something persistency related? There hasn't been any event after I edited the webhook settings. (basically a no-op): Enable `Statuses` -> Apply -> Disable `Statuses` -> Apply

GiteaMirror commented

@wolfaba commented on GitHub (Feb 6, 2025):

In our environment the version 1.23.3 is working fine now.

@wolfaba commented on GitHub (Feb 6, 2025): In our environment the version 1.23.3 is working fine now.

GiteaMirror commented

@balki commented on GitHub (Feb 6, 2025):

Same issue with a bunch of status messages and the telegram webhook went red due to 429 response.
My hook settings:

Hook type: telegram

Bot Token: XXXXXXXXXXXXX
Chat ID: ###########
Thread ID:

Trigger On:
Custom Events...
Repository Events
[✓] Create (Branch or tag created)

Branch filter: tag
[✓] Active

Example message:

{
  "text": "Commit Status changed: \u003ca href=\"/XXXXX/yyy/actions/runs/29/jobs/2\" rel=\"nofollow\"\u003e/ MacOS Go 1.23 (push)[dbe350a5859b98ef8e1d5aa65dc21ef150bff85e]:Waiting to run\u003c/a\u003e by \u003ca href=\"https://gitea.aaaa.bbb/gitea-actions\" rel=\"nofollow\"\u003egitea-actions\u003c/a\u003e",
  "parse_mode": "HTML",
  "disable_web_page_preview": true
}

Gitea version: 1.23.3 (archlinux)

@balki commented on GitHub (Feb 6, 2025): Same issue with a bunch of status messages and the telegram webhook went red due to 429 response. My hook settings: Hook type: telegram Bot Token: XXXXXXXXXXXXX Chat ID: ########### Thread ID: <Empty> Trigger On: Custom Events... Repository Events [✓] Create (Branch or tag created) Branch filter: `tag` [✓] Active --- Example message: ```json { "text": "Commit Status changed: \u003ca href=\"/XXXXX/yyy/actions/runs/29/jobs/2\" rel=\"nofollow\"\u003e/ MacOS Go 1.23 (push)[dbe350a5859b98ef8e1d5aa65dc21ef150bff85e]:Waiting to run\u003c/a\u003e by \u003ca href=\"https://gitea.aaaa.bbb/gitea-actions\" rel=\"nofollow\"\u003egitea-actions\u003c/a\u003e", "parse_mode": "HTML", "disable_web_page_preview": true } ``` Gitea version: 1.23.3 (archlinux)

GiteaMirror commented

@balki commented on GitHub (Feb 7, 2025):

Not just "Commit status" messages. Today got spammed with 'merge-requests created messages'. The hook is just supposed to notify on new tags created.

{
  "text": "[\u003ca href=\"https://gitea.aaaa.bb/XXXXX/YYYY\" rel=\"nofollow\"\u003eXXXXX/YYYY\u003c/a\u003e]  \u003ca href=\"https://gitea.aaaa.bbb/XXXXX/YYYY/src/refs/merge-requests/8779/merge\" rel=\"nofollow\"\u003erefs/merge-requests/8779/merge\u003c/a\u003e created",
  "parse_mode": "HTML",
  "disable_web_page_preview": true
}

@balki commented on GitHub (Feb 7, 2025): Not just "Commit status" messages. Today got spammed with 'merge-requests created messages'. The hook is just supposed to notify on new tags created. ``` { "text": "[\u003ca href=\"https://gitea.aaaa.bb/XXXXX/YYYY\" rel=\"nofollow\"\u003eXXXXX/YYYY\u003c/a\u003e] \u003ca href=\"https://gitea.aaaa.bbb/XXXXX/YYYY/src/refs/merge-requests/8779/merge\" rel=\"nofollow\"\u003erefs/merge-requests/8779/merge\u003c/a\u003e created", "parse_mode": "HTML", "disable_web_page_preview": true } ```

GiteaMirror commented

@lunny commented on GitHub (Feb 10, 2025):

Same issue with a bunch of status messages and the telegram webhook went red due to 429 response. My hook settings:

Hook type: telegram

Bot Token: XXXXXXXXXXXXX Chat ID: ########### Thread ID:

Trigger On: Custom Events... Repository Events [✓] Create (Branch or tag created)

Branch filter: tag [✓] Active

Example message:

{
"text": "Commit Status changed: \u003ca href="/XXXXX/yyy/actions/runs/29/jobs/2" rel="nofollow"\u003e/ MacOS Go 1.23 (push)[dbe350a5859b98ef8e1d5aa65dc21ef150bff85e]:Waiting to run\u003c/a\u003e by \u003ca href="https://gitea.aaaa.bbb/gitea-actions" rel="nofollow"\u003egitea-actions\u003c/a\u003e",
"parse_mode": "HTML",
"disable_web_page_preview": true
}

Gitea version: 1.23.3 (archlinux)

Have you check your webhook configuration, whether it includes Statuses?

@lunny commented on GitHub (Feb 10, 2025): > Same issue with a bunch of status messages and the telegram webhook went red due to 429 response. My hook settings: > > Hook type: telegram > > Bot Token: XXXXXXXXXXXXX Chat ID: ########### Thread ID: > > Trigger On: Custom Events... Repository Events [✓] Create (Branch or tag created) > > Branch filter: `tag` [✓] Active > > Example message: > > { > "text": "Commit Status changed: \u003ca href=\"/XXXXX/yyy/actions/runs/29/jobs/2\" rel=\"nofollow\"\u003e/ MacOS Go 1.23 (push)[dbe350a5859b98ef8e1d5aa65dc21ef150bff85e]:Waiting to run\u003c/a\u003e by \u003ca href=\"https://gitea.aaaa.bbb/gitea-actions\" rel=\"nofollow\"\u003egitea-actions\u003c/a\u003e", > "parse_mode": "HTML", > "disable_web_page_preview": true > } > > Gitea version: 1.23.3 (archlinux) Have you check your webhook configuration, whether it includes `Statuses`?

GiteaMirror commented

@lunny commented on GitHub (Feb 10, 2025):

Please check if you have any other high-level webhooks configured to receive all events. I am unable to reproduce the issue on my end.

@lunny commented on GitHub (Feb 10, 2025): Please check if you have any other high-level webhooks configured to receive all events. I am unable to reproduce the issue on my end.

GiteaMirror commented

@ZantsuRocks commented on GitHub (Feb 10, 2025):

I have 3 webhook and none of them send commit status. My discord server was flooded with commit status chances from CI in all three webhooks...

Gitea Version is 1.23.3 and as soon as i updated from 1.23.1 to 1.23.3 and started the service my discord began to popup the notifications.
The only way to stop was disabling all 3 webhooks.

@ZantsuRocks commented on GitHub (Feb 10, 2025): I have 3 webhook and none of them send commit status. My discord server was flooded with commit status chances from CI in all three webhooks... Gitea Version is 1.23.3 and as soon as i updated from 1.23.1 to 1.23.3 and started the service my discord began to popup the notifications. The only way to stop was disabling all 3 webhooks. ![Image](https://github.com/user-attachments/assets/bdc8ac88-9d1e-43ac-82ba-1674715765f9) ![Image](https://github.com/user-attachments/assets/f9dfe221-f9da-46ee-9939-77871ffdead2) ![Image](https://github.com/user-attachments/assets/dcf1516e-e170-4cbf-9677-84e446a0421d) ![Image](https://github.com/user-attachments/assets/39871365-e574-4ebd-a418-dd226b6dab6e)

GiteaMirror commented

@lunny commented on GitHub (Feb 10, 2025):

I have 3 webhook and none of them send commit status. My discord server was flooded with commit status chances from CI in all three webhooks...

Gitea Version is 1.23.3 and as soon as i updated from 1.23.1 to 1.23.3 and started the service my discord began to popup the notifications. The only way to stop was disabling all 3 webhooks.

Can you enable statuses and disable statuses and active it to try again?

@lunny commented on GitHub (Feb 10, 2025): > I have 3 webhook and none of them send commit status. My discord server was flooded with commit status chances from CI in all three webhooks... > > Gitea Version is 1.23.3 and as soon as i updated from 1.23.1 to 1.23.3 and started the service my discord began to popup the notifications. The only way to stop was disabling all 3 webhooks. > > ![Image](https://github.com/user-attachments/assets/bdc8ac88-9d1e-43ac-82ba-1674715765f9) > > ![Image](https://github.com/user-attachments/assets/f9dfe221-f9da-46ee-9939-77871ffdead2) > > ![Image](https://github.com/user-attachments/assets/dcf1516e-e170-4cbf-9677-84e446a0421d) > > ![Image](https://github.com/user-attachments/assets/39871365-e574-4ebd-a418-dd226b6dab6e) Can you enable statuses and disable statuses and active it to try again?

GiteaMirror commented

@lunny commented on GitHub (Feb 10, 2025):

Can you also check the history of this webhook and check the event types on the http headers.

@lunny commented on GitHub (Feb 10, 2025): Can you also check the history of this webhook and check the event types on the http headers.

GiteaMirror commented

@ZantsuRocks commented on GitHub (Feb 10, 2025):

Can you also check the history of this webhook and check the event types on the http headers.

One of the items:
Request:

Request URL: https://discord.com/api/webhooks/########################
Request method: POST
Content-Type: application/json
X-GitHub-Delivery: 08140e31-7b66-4bda-9e3f-76447c8866f0
X-GitHub-Event: status
X-GitHub-Event-Type: status
X-Gitea-Delivery: 08140e31-7b66-4bda-9e3f-76447c8866f0
X-Gitea-Event: status
X-Gitea-Event-Type: status
X-Gitea-Signature: 
X-Gogs-Delivery: 08140e31-7b66-4bda-9e3f-76447c8866f0
X-Gogs-Event: status
X-Gogs-Event-Type: status
X-Gogs-Signature: 
X-Hub-Signature: sha1=
X-Hub-Signature-256: sha256=

Content:

{
  "wait": false,
  "content": "",
  "username": "Lançamento de Versões",
  "avatar_url": "https://static-00.iconduck.com/assets.00/gitea-icon-512x512-8lvcua7z.png",
  "tts": false,
  "embeds": [
    {
      "title": "Commit Status changed: continuous-integration/drone/push[6318b2c2a6b71473da43d8baa7dbe0d66f1e0a28]:Build is running",
      "description": "",
      "url": "https://MY-CI-DOMAIN/AGST/AirSense/79",
      "color": 1754624,
      "footer": {
        "text": ""
      },
      "author": {
        "name": "wagner.rebello",
        "url": "https://MY-DOMAIN/wagner.rebello",
        "icon_url": "https://MY-DOMAIN/avatars/53171ee2606976be490df98ed8780cf2fb51e1c6527ebbbcdc7958d017b26cf7"
      },
      "fields": null
    }
  ]
}

I will try to reenable the hooks tomorrow with status enabled, and disabled again.

@ZantsuRocks commented on GitHub (Feb 10, 2025): > Can you also check the history of this webhook and check the event types on the http headers. One of the items: Request: ``` Request URL: https://discord.com/api/webhooks/######################## Request method: POST Content-Type: application/json X-GitHub-Delivery: 08140e31-7b66-4bda-9e3f-76447c8866f0 X-GitHub-Event: status X-GitHub-Event-Type: status X-Gitea-Delivery: 08140e31-7b66-4bda-9e3f-76447c8866f0 X-Gitea-Event: status X-Gitea-Event-Type: status X-Gitea-Signature: X-Gogs-Delivery: 08140e31-7b66-4bda-9e3f-76447c8866f0 X-Gogs-Event: status X-Gogs-Event-Type: status X-Gogs-Signature: X-Hub-Signature: sha1= X-Hub-Signature-256: sha256= ``` Content: ```json { "wait": false, "content": "", "username": "Lançamento de Versões", "avatar_url": "https://static-00.iconduck.com/assets.00/gitea-icon-512x512-8lvcua7z.png", "tts": false, "embeds": [ { "title": "Commit Status changed: continuous-integration/drone/push[6318b2c2a6b71473da43d8baa7dbe0d66f1e0a28]:Build is running", "description": "", "url": "https://MY-CI-DOMAIN/AGST/AirSense/79", "color": 1754624, "footer": { "text": "" }, "author": { "name": "wagner.rebello", "url": "https://MY-DOMAIN/wagner.rebello", "icon_url": "https://MY-DOMAIN/avatars/53171ee2606976be490df98ed8780cf2fb51e1c6527ebbbcdc7958d017b26cf7" }, "fields": null } ] } ``` I will try to reenable the hooks tomorrow with status enabled, and disabled again.

GiteaMirror commented

@otbutz commented on GitHub (Feb 11, 2025):

@lunny this has to be something related to persistency and/or database migrations.

Enable Statuses -> Apply -> Disable Statuses -> Apply

Not a single false notification since.

@otbutz commented on GitHub (Feb 11, 2025): @lunny this has to be something related to persistency and/or database migrations. > Enable `Statuses` -> Apply -> Disable `Statuses` -> Apply Not a single false notification since.

GiteaMirror commented

@ZantsuRocks commented on GitHub (Feb 11, 2025):

After enabling and disabling the statuses it seems that the hook works as intended.

@ZantsuRocks commented on GitHub (Feb 11, 2025): After enabling and disabling the statuses it seems that the hook works as intended.

GiteaMirror commented

@lunny commented on GitHub (May 30, 2025):

Is this still a problem?

@lunny commented on GitHub (May 30, 2025): Is this still a problem?

GiteaMirror commented

@wolfaba commented on GitHub (May 30, 2025):

Is this still a problem?

I have confirmed in https://github.com/go-gitea/gitea/issues/33302#issuecomment-2639940402 that version 1.23.3 is working fine for us

@wolfaba commented on GitHub (May 30, 2025): > Is this still a problem? I have confirmed in https://github.com/go-gitea/gitea/issues/33302#issuecomment-2639940402 that version 1.23.3 is working fine for us

GiteaMirror commented