Inconsistent Link Rendering in Frontend UI on Gitea v1.23.x #13985

@wxiaoguang commented on GitHub (Jan 14, 2025):

Because the translation has changed. If you are using customized translations, you need to follow the changes. The links have been moved out of the strings.

https://github.com/go-gitea/gitea/blob/release/v1.23/options/locale/locale_en-US.ini#L237

install_desc = Simply <a target="_blank" rel="noopener noreferrer" href="%[1]s">run the binary</a> for your platform, ship it with <a target="_blank" rel="noopener noreferrer" href="%[2]s">Docker</a>, or get it <a target="_blank" rel="noopener noreferrer" href="%[3]s">packaged</a>.

https://github.com/go-gitea/gitea/blame/release/v1.22/options/locale/locale_en-US.ini#L227

install_desc = Simply <a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.com/installation/install-from-binary">run the binary</a> for your platform, ship it with <a target="_blank" rel="noopener noreferrer" href="https://github.com/go-gitea/gitea/tree/master/docker">Docker</a>, or get it <a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.com/installation/install-from-package">packaged</a>.

If you need to customize, it's better to customize the home.tmpl

@wxiaoguang commented on GitHub (Jan 14, 2025): Because the translation has changed. If you are using customized translations, you need to follow the changes. The links have been moved out of the strings. * https://github.com/go-gitea/gitea/blob/release/v1.23/options/locale/locale_en-US.ini#L237 ``` install_desc = Simply <a target="_blank" rel="noopener noreferrer" href="%[1]s">run the binary</a> for your platform, ship it with <a target="_blank" rel="noopener noreferrer" href="%[2]s">Docker</a>, or get it <a target="_blank" rel="noopener noreferrer" href="%[3]s">packaged</a>. ``` * https://github.com/go-gitea/gitea/blame/release/v1.22/options/locale/locale_en-US.ini#L227 ``` install_desc = Simply <a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.com/installation/install-from-binary">run the binary</a> for your platform, ship it with <a target="_blank" rel="noopener noreferrer" href="https://github.com/go-gitea/gitea/tree/master/docker">Docker</a>, or get it <a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.com/installation/install-from-package">packaged</a>. ``` If you need to customize, it's better to customize the `home.tmpl`

GiteaMirror commented

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

Because the translation has changed. If you are using customized translations, you need to follow the changes. The links have been moved out of the strings.
install_desc = Simply <a target="_blank" rel="noopener noreferrer" href="%[1]s">run the binary</a> for your platform, ship it with <a target="_blank" rel="noopener noreferrer" href="%[2]s">Docker</a>, or get it <a target="_blank" rel="noopener noreferrer" href="%[3]s">packaged</a>.
https://github.com/go-gitea/gitea/blame/release/v1.22/options/locale/locale_en-US.ini#L227

https://github.com/go-gitea/gitea/blob/release/v1.23/options/locale/locale_en-US.ini#L237

If you need to customize, it's better to customize the home.tmpl

I don't use custom translations; it was the original. Do I need to update it manually?

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): > Because the translation has changed. If you are using customized translations, you need to follow the changes. The links have been moved out of the strings. > > ``` > install_desc = Simply <a target="_blank" rel="noopener noreferrer" href="%[1]s">run the binary</a> for your platform, ship it with <a target="_blank" rel="noopener noreferrer" href="%[2]s">Docker</a>, or get it <a target="_blank" rel="noopener noreferrer" href="%[3]s">packaged</a>. > ``` > > * https://github.com/go-gitea/gitea/blame/release/v1.22/options/locale/locale_en-US.ini#L227 > * https://github.com/go-gitea/gitea/blob/release/v1.23/options/locale/locale_en-US.ini#L237 > > If you need to customize, it's better to customize the `home.tmpl` I don't use custom translations; it was the original. Do I need to update it manually?

GiteaMirror commented

@wxiaoguang commented on GitHub (Jan 14, 2025):

``

I don't use custom translations; it was the original. Do I need to update it manually?

No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets.

@wxiaoguang commented on GitHub (Jan 14, 2025): > > `` > > I don't use custom translations; it was the original. Do I need to update it manually? No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets.

GiteaMirror commented

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

``

I don't use custom translations; it was the original. Do I need to update it manually?

No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets.

Nah, I only changed the title and description through the app.ini configuration. I use Gitea solely to store repositories in Kubernetes for development, sandbox, and production. The about page is entirely original from Gitea because I didn't change anything else. My focus is on storing repositories so they can be easily managed by Kubernetes for development, sandbox, and production.

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): > > > `` > > > > > > I don't use custom translations; it was the original. Do I need to update it manually? > > No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets. Nah, I only changed the title and description through the `app.ini` configuration. I use Gitea solely to store repositories in Kubernetes for development, sandbox, and production. The about page is entirely original from Gitea because I didn't change anything else. My focus is on storing repositories so they can be easily managed by Kubernetes for development, sandbox, and production.

GiteaMirror commented

@wxiaoguang commented on GitHub (Jan 14, 2025):

``

I don't use custom translations; it was the original. Do I need to update it manually?

No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets.

Nah, I only changed the title and description through the app.ini configuration. I use Gitea solely to store repositories in Kubernetes for development, sandbox, and production. The about page is entirely original from Gitea because I didn't change anything else. My focus is on storing repositories so they can be easily managed by Kubernetes for development, sandbox, and production.

That's strange, how do you run Gitea? Could you provide the setup details? There seems to be something wrong in the setup.

@wxiaoguang commented on GitHub (Jan 14, 2025): > > > > `` > > > > > > > > > I don't use custom translations; it was the original. Do I need to update it manually? > > > > > > No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets. > > Nah, I only changed the title and description through the `app.ini` configuration. I use Gitea solely to store repositories in Kubernetes for development, sandbox, and production. The about page is entirely original from Gitea because I didn't change anything else. My focus is on storing repositories so they can be easily managed by Kubernetes for development, sandbox, and production. That's strange, how do you run Gitea? Could you provide the setup details? There seems to be something wrong in the setup.

GiteaMirror commented

@wxiaoguang commented on GitHub (Jan 14, 2025):

Or, could you just download the binary or use a docker compose to start a new instance to see whether the translations are right?

@wxiaoguang commented on GitHub (Jan 14, 2025): Or, could you just download the binary or use a docker compose to start a new instance to see whether the translations are right?

GiteaMirror commented

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

``

I don't use custom translations; it was the original. Do I need to update it manually?

No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets.

Nah, I only changed the title and description through the app.ini configuration. I use Gitea solely to store repositories in Kubernetes for development, sandbox, and production. The about page is entirely original from Gitea because I didn't change anything else. My focus is on storing repositories so they can be easily managed by Kubernetes for development, sandbox, and production.

That's strange, how do you run Gitea? Could you provide the setup details? There seems to be something wrong in the setup.

Or, could you just download the binary or use a docker compose to start a new instance to see whether the translations are right?

Here is my deployment example:

Name:                   gitea
Namespace:              gitea
CreationTimestamp:      Tue, 26 Nov 2024 09:20:00 +0700
Labels:                 <none>
Annotations:            deployment.kubernetes.io/revision: 52
Selector:               app=gitea
Replicas:               1 desired | 1 updated | 1 total | 1 available | 0 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  1 max unavailable, 5% max surge
Pod Template:
  Labels:       app=gitea
  Annotations:  kubectl.kubernetes.io/restartedAt: 2025-01-10T09:14:51+07:00
  Containers:
   gitea:
    Image:      gitea/gitea:latest
    Port:       3000/TCP
    Host Port:  0/TCP
    Limits:
      cpu:     1
      memory:  600Mi
    Requests:
      cpu:     350m
      memory:  456Mi
    Environment:
      GITEA_TEMP:  /data/tmp/gitea
    Mounts:
      /data from gitea-data (rw)
      /data/gitea/tls from gitea-tls (ro)
  Volumes:
   gitea-data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  gitea-storage
    ReadOnly:   false
   gitea-tls:
    Type:               Secret (a volume populated by a Secret)
    SecretName:         gitea-ingress-https
    Optional:           false

My Kubernetes deployment is not using charts like Helm. I wrote it myself because it's easier.

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): > > > > > `` > > > > > > > > > > > > I don't use custom translations; it was the original. Do I need to update it manually? > > > > > > > > > No, have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets. > > > > > > Nah, I only changed the title and description through the `app.ini` configuration. I use Gitea solely to store repositories in Kubernetes for development, sandbox, and production. The about page is entirely original from Gitea because I didn't change anything else. My focus is on storing repositories so they can be easily managed by Kubernetes for development, sandbox, and production. > > That's strange, how do you run Gitea? Could you provide the setup details? There seems to be something wrong in the setup. > Or, could you just download the binary or use a docker compose to start a new instance to see whether the translations are right? Here is my deployment example: ``` Name: gitea Namespace: gitea CreationTimestamp: Tue, 26 Nov 2024 09:20:00 +0700 Labels: <none> Annotations: deployment.kubernetes.io/revision: 52 Selector: app=gitea Replicas: 1 desired | 1 updated | 1 total | 1 available | 0 unavailable StrategyType: RollingUpdate MinReadySeconds: 0 RollingUpdateStrategy: 1 max unavailable, 5% max surge Pod Template: Labels: app=gitea Annotations: kubectl.kubernetes.io/restartedAt: 2025-01-10T09:14:51+07:00 Containers: gitea: Image: gitea/gitea:latest Port: 3000/TCP Host Port: 0/TCP Limits: cpu: 1 memory: 600Mi Requests: cpu: 350m memory: 456Mi Environment: GITEA_TEMP: /data/tmp/gitea Mounts: /data from gitea-data (rw) /data/gitea/tls from gitea-tls (ro) Volumes: gitea-data: Type: PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace) ClaimName: gitea-storage ReadOnly: false gitea-tls: Type: Secret (a volume populated by a Secret) SecretName: gitea-ingress-https Optional: false ``` My Kubernetes deployment is not using charts like Helm. I wrote it myself because it's easier.

GiteaMirror commented

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

Also, if I roll back to the previous version, the deployment works properly About Inconsistent Link Rendering.

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): Also, if I roll back to the previous version, the deployment works properly About Inconsistent Link Rendering.

GiteaMirror commented

@wxiaoguang commented on GitHub (Jan 14, 2025):

It seems right here:

  server:
    image: gitea/gitea:latest
    container_name: gitea-1.23
    volumes:
      - ./gitea:/data
    ports:
      - "3023:3000"
      - "3223:22"

@wxiaoguang commented on GitHub (Jan 14, 2025): It seems right here: ```services: server: image: gitea/gitea:latest container_name: gitea-1.23 volumes: - ./gitea:/data ports: - "3023:3000" - "3223:22" ``` <details> ![image](https://github.com/user-attachments/assets/9771658a-20a1-447a-9e39-fe24ba477726) </details>

GiteaMirror commented

2025-11-02 10:59:14 -06:00

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

It seems right here:

  server:
    image: gitea/gitea:latest
    container_name: gitea-1.23
    volumes:
      - ./gitea:/data
    ports:
      - "3023:3000"
      - "3223:22"

are you running on docker ?

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): > It seems right here: > > ``` > server: > image: gitea/gitea:latest > container_name: gitea-1.23 > volumes: > - ./gitea:/data > ports: > - "3023:3000" > - "3223:22" > ``` > > ![image](https://private-user-images.githubusercontent.com/2114189/402863169-9771658a-20a1-447a-9e39-fe24ba477726.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY4NDM5ODUsIm5iZiI6MTczNjg0MzY4NSwicGF0aCI6Ii8yMTE0MTg5LzQwMjg2MzE2OS05NzcxNjU4YS0yMGExLTQ0N2EtOWUzOS1mZTI0YmE0Nzc3MjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDExNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAxMTRUMDgzNDQ1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODFhMGRlNzVmNzNlM2MwZjI2NGRmZmZiOWM3YWI5OGM5YWNkNTA1ODgwNmE4MDQ3OTU2NWExNzU5ZWNjZjI4YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.pnjgF1BbK2aYHyxmY7SspRXN0s-obcwNWAR1_QzYfok) are you running on docker ?

GiteaMirror commented

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

this is my home.tmpl. Previously, I edited it only to add a privacy policy:

{{template "base/head" .}}                                                                                                                   
<div role="main" aria-label="{{if .IsSigned}}{{ctx.Locale.Tr "dashboard"}}{{else}}{{ctx.Locale.Tr "home"}}{{end}}" class="page-content home">
    <div class="tw-mb-8 tw-px-8">                                                                                                   
        <div class="center">                                                                                                    
            <img class="logo" width="220" height="220" src="{{AssetUrlPrefix}}/img/logo.svg" alt="{{ctx.Locale.Tr "logo"}}">
            <div class="hero">                                     
                <h1 class="ui icon header title">              
                    {{AppName}}                            
                </h1>                                          
                <h2>{{ctx.Locale.Tr "startpage.app_desc"}}</h2>              
            </div>                                                               
        </div>                                                                       
    </div>                                                                               
    <div class="ui stackable middle very relaxed page grid">                             
        <div class="eight wide center column">                                       
            <h1 class="hero ui icon header">                                     
                {{svg "octicon-flame"}} {{ctx.Locale.Tr "startpage.install"}}
            </h1>                                                                          
            <p class="large">                                                              
                {{ctx.Locale.Tr "startpage.install_desc"}}                             
            </p>                                                                           
        </div>                                                                                 
        <div class="eight wide center column">                                                 
            <h1 class="hero ui icon header">                                               
                {{svg "octicon-device-desktop"}} {{ctx.Locale.Tr "startpage.platform"}}
            </h1>                                              
            <p class="large">                                  
                {{ctx.Locale.Tr "startpage.platform_desc"}}                       
            </p>                                                                      
        </div>                                                                            
    </div>                                                                                    
    <div class="ui stackable middle very relaxed page grid">                                  
        <div class="eight wide center column">                                            
            <h1 class="hero ui icon header">                                          
                {{svg "octicon-rocket"}} {{ctx.Locale.Tr "startpage.lightweight"}}
            </h1>                                                               
            <p class="large">                                                   
                {{ctx.Locale.Tr "startpage.lightweight_desc"}}              
            </p>                                                                
        </div>                                                                      
        <div class="eight wide center column">                                      
            <h1 class="hero ui icon header">                                    
                {{svg "octicon-code"}} {{ctx.Locale.Tr "startpage.license"}}
            </h1>                                                               
            <p class="large">                                                   
                {{ctx.Locale.Tr "startpage.license_desc"}}                  
            </p>                                                                
        </div>                                                                      
    </div>                                                                              
</div>                                                                                      
{{template "base/footer" .}}

The custom privacy policy template:

<a class="item" href="{{AppSubUrl}}/assets/privacy.html">Privacy Policy</a>

Note

In the previous version, it worked properly.

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): this is my `home.tmpl`. Previously, I edited it only to add a privacy policy: ```tmpl {{template "base/head" .}} <div role="main" aria-label="{{if .IsSigned}}{{ctx.Locale.Tr "dashboard"}}{{else}}{{ctx.Locale.Tr "home"}}{{end}}" class="page-content home"> <div class="tw-mb-8 tw-px-8"> <div class="center"> <img class="logo" width="220" height="220" src="{{AssetUrlPrefix}}/img/logo.svg" alt="{{ctx.Locale.Tr "logo"}}"> <div class="hero"> <h1 class="ui icon header title"> {{AppName}} </h1> <h2>{{ctx.Locale.Tr "startpage.app_desc"}}</h2> </div> </div> </div> <div class="ui stackable middle very relaxed page grid"> <div class="eight wide center column"> <h1 class="hero ui icon header"> {{svg "octicon-flame"}} {{ctx.Locale.Tr "startpage.install"}} </h1> <p class="large"> {{ctx.Locale.Tr "startpage.install_desc"}} </p> </div> <div class="eight wide center column"> <h1 class="hero ui icon header"> {{svg "octicon-device-desktop"}} {{ctx.Locale.Tr "startpage.platform"}} </h1> <p class="large"> {{ctx.Locale.Tr "startpage.platform_desc"}} </p> </div> </div> <div class="ui stackable middle very relaxed page grid"> <div class="eight wide center column"> <h1 class="hero ui icon header"> {{svg "octicon-rocket"}} {{ctx.Locale.Tr "startpage.lightweight"}} </h1> <p class="large"> {{ctx.Locale.Tr "startpage.lightweight_desc"}} </p> </div> <div class="eight wide center column"> <h1 class="hero ui icon header"> {{svg "octicon-code"}} {{ctx.Locale.Tr "startpage.license"}} </h1> <p class="large"> {{ctx.Locale.Tr "startpage.license_desc"}} </p> </div> </div> </div> {{template "base/footer" .}} ``` The custom privacy policy template: ```tmpl <a class="item" href="{{AppSubUrl}}/assets/privacy.html">Privacy Policy</a> ``` > [!NOTE] > In the previous version, it worked properly.

GiteaMirror commented

2025-11-02 10:59:14 -06:00

@yp05327 commented on GitHub (Jan 14, 2025):

In your template:

The original one:
fcbbc24cc4/templates/home.tmpl (L46)

It is changed in 1.23.x, see: https://github.com/go-gitea/gitea/pull/31950/files#diff-94cc12aece6a3ade829fe9dae489133c4fb748cfb318b0849a8483101fe35ed2R46

@yp05327 commented on GitHub (Jan 14, 2025): In your template: ![image](https://github.com/user-attachments/assets/e5c57ff1-81d7-47c3-8542-9b7faa4880f9) The original one: https://github.com/go-gitea/gitea/blob/fcbbc24cc43811f2fc2f99b2f88060bc360ec38f/templates/home.tmpl#L46 It is changed in 1.23.x, see: https://github.com/go-gitea/gitea/pull/31950/files#diff-94cc12aece6a3ade829fe9dae489133c4fb748cfb318b0849a8483101fe35ed2R46

GiteaMirror commented

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

In your template: The original one:

fcbbc24cc4/templates/home.tmpl (L46)

It is changed in 1.23.x, see: https://github.com/go-gitea/gitea/pull/31950/files#diff-94cc12aece6a3ade829fe9dae489133c4fb748cfb318b0849a8483101fe35ed2R46

I see this because my home.tmpl is an old version, which is why it only works with the old version of Gitea.

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): > In your template: ![image](https://private-user-images.githubusercontent.com/18380374/402871491-e5c57ff1-81d7-47c3-8542-9b7faa4880f9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY4NDU0NTAsIm5iZiI6MTczNjg0NTE1MCwicGF0aCI6Ii8xODM4MDM3NC80MDI4NzE0OTEtZTVjNTdmZjEtODFkNy00N2MzLTg1NDItOWI3ZmFhNDg4MGY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAxMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMTE0VDA4NTkxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxYjRiZjhjOWFmMTU5ODE4MWNlOTBiNDUyMzVlNmU1ZTdhYjVkM2I5OWRmYThiN2IzMTA1MTA5ZjM0NDFkMjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pInrGtNjQJUo84Yvl6fMlESB3Gu3xAkrWewGOTuBTAM) The original one: > > https://github.com/go-gitea/gitea/blob/fcbbc24cc43811f2fc2f99b2f88060bc360ec38f/templates/home.tmpl#L46 > > It is changed in 1.23.x, see: https://github.com/go-gitea/gitea/pull/31950/files#diff-94cc12aece6a3ade829fe9dae489133c4fb748cfb318b0849a8483101fe35ed2R46 I see this because my `home.tmpl` is an old version, which is why it only works with the old version of Gitea.

GiteaMirror commented

@H0llyW00dzZ commented on GitHub (Jan 14, 2025):

Anyway, it's fixed now. I thought it was a bug.

@H0llyW00dzZ commented on GitHub (Jan 14, 2025): Anyway, it's fixed now. I thought it was a bug. ![image](https://github.com/user-attachments/assets/a971dff1-9122-4e91-b545-d5dd2f9c666d)

GiteaMirror commented

@wxiaoguang commented on GitHub (Jan 14, 2025):

Anyway, it's fixed now. I thought it was a bug.

That's what we have discussed: "have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets": out-dated templates might not work for latest release.

If you "customize", then you need to make sure the customized assets match Gitea's

@wxiaoguang commented on GitHub (Jan 14, 2025): > Anyway, it's fixed now. I thought it was a bug. That's what we have discussed: "have you extracted Gitea's custom assets? It would make new Gitea binary use out-dated old assets": out-dated templates might not work for latest release. If you "customize", then you need to make sure the customized assets match Gitea's

GiteaMirror commented