github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Performance problem about pin issue #13961

New Issue
Closed
opened 2025-11-02 10:58:28 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 10:58:28 -06:00
Owner
Copy Link

Originally created by @lunny on GitHub (Jan 11, 2025).

This SQL is slow because pin_order is not an index column. After reviewing #24406 again, I prefer to create a new table to store pin order like https://github.com/go-gitea/gitea/pull/24406#issuecomment-1527747296 described by @delvh

SELECT `id`, `repo_id`, `index`, `poster_id`, `original_author`, `original_author_id`, `name`, `content`, `content_version`, `milestone_id`, `priority`, `is_closed`, `is_pull`, `num_comments`, `ref`, `pin_order`, `deadline_unix`, `created_unix`, `updated_unix`, `closed_unix`, `is_locked`, `time_estimate` FROM `issue` WHERE (repo_id = xxx) AND (is_pull = 0) AND (pin_order > 0) ORDER BY pin_order

Another idea is to add an index for column pin_order but we will have more and more index columns which is still a problem.

Originally created by @lunny on GitHub (Jan 11, 2025). This SQL is slow because `pin_order` is not an index column. After reviewing #24406 again, I prefer to create a new table to store pin order like https://github.com/go-gitea/gitea/pull/24406#issuecomment-1527747296 described by @delvh ```SQL SELECT `id`, `repo_id`, `index`, `poster_id`, `original_author`, `original_author_id`, `name`, `content`, `content_version`, `milestone_id`, `priority`, `is_closed`, `is_pull`, `num_comments`, `ref`, `pin_order`, `deadline_unix`, `created_unix`, `updated_unix`, `closed_unix`, `is_locked`, `time_estimate` FROM `issue` WHERE (repo_id = xxx) AND (is_pull = 0) AND (pin_order > 0) ORDER BY pin_order ``` Another idea is to add an index for column `pin_order` but we will have more and more index columns which is still a problem.
GiteaMirror added the performance/bigrepo label 2025-11-02 10:58:28 -06:00
GiteaMirror commented 2025-11-02 10:58:29 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 15, 2025):

Resolved by #33452

@lunny commented on GitHub (Oct 15, 2025): Resolved by #33452
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label performance/bigrepo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?