auth/pam test fails with v1.23.0 #13941

New Issue

GiteaMirror · 2025-11-02T10:57:53-06:00

GiteaMirror commented

2025-11-02 10:57:53 -06:00

Originally created by @Antiz96 on GitHub (Jan 9, 2025).

Description

Hi,

When building Gitea 1.23.0, the auth/pam test is failing when running make test:

[...]
modules/auth/pam/pam_test.go:18:16: not enough arguments in call to assert.Len
[...]
FAIL    code.gitea.io/gitea/modules/auth/pam [build failed]
[...]
FAIL
make: *** [Makefile:473: test-backend] Error 1

It passes fine when building previous versions however (e.g. 1.22.6).

The build and test instructions we use are available here.

I remain available if needed :)

Gitea Version

1.23.0

Can you reproduce the bug on the Gitea demo site?

N/A

Log Gist

Provided in the description

Screenshots

N/A

Git Version

The build and test env is using git 2.47.1

Operating System

Arch Linux

How are you running Gitea?

N/A

Database

N/A

Originally created by @Antiz96 on GitHub (Jan 9, 2025). ### Description Hi, When building Gitea 1.23.0, the `auth/pam` test is failing when running `make test`: ``` [...] modules/auth/pam/pam_test.go:18:16: not enough arguments in call to assert.Len [...] FAIL code.gitea.io/gitea/modules/auth/pam [build failed] [...] FAIL make: *** [Makefile:473: test-backend] Error 1 ``` It passes fine when building previous versions however (e.g. 1.22.6). - [Full build logs](https://gist.github.com/Antiz96/fccadf101facc9aaa2780d9971c86da5#file-build-logs) - [Full test logs](https://gist.github.com/Antiz96/fccadf101facc9aaa2780d9971c86da5#file-check-logs) The build and test instructions we use are available [here](https://gitlab.archlinux.org/archlinux/packaging/packages/gitea/-/blob/main/PKGBUILD?ref_type=heads#L50-65). I remain available if needed :) ### Gitea Version 1.23.0 ### Can you reproduce the bug on the Gitea demo site? N/A ### Log Gist Provided in the description ### Screenshots N/A ### Git Version The build and test env is using git 2.47.1 ### Operating System Arch Linux ### How are you running Gitea? N/A ### Database N/A

GiteaMirror added the type/bug label 2025-11-02 10:57:53 -06:00

GiteaMirror closed this issue

2025-11-02 10:57:53 -06:00

GiteaMirror commented

2025-11-02 10:57:54 -06:00

@TheFox0x7 commented on GitHub (Jan 9, 2025):

my bad, not sure how it didn't trigger any lint issues.

Is pam test not run in CI?

@TheFox0x7 commented on GitHub (Jan 9, 2025): my bad, not sure how it didn't trigger any lint issues. Is pam test not run in CI?

GiteaMirror commented

2025-11-02 10:57:54 -06:00

@Antiz96 commented on GitHub (Jan 9, 2025):

my bad, not sure how it didn't trigger any lint issues.

No problem, thanks for the very quick actions! 🙏
I can confirm the fix provided in https://github.com/go-gitea/gitea/pull/33169 fixes the issue 😄

@Antiz96 commented on GitHub (Jan 9, 2025): > my bad, not sure how it didn't trigger any lint issues. No problem, thanks for the *very* quick actions! :pray: I can confirm the fix provided in https://github.com/go-gitea/gitea/pull/33169 fixes the issue :smile:

GiteaMirror commented

2025-11-02 10:57:54 -06:00

@wxiaoguang commented on GitHub (Jan 9, 2025):

Is pam test not run in CI?

Hmm .... it seems that pam test doesn't run in CI because there is no pam build tag.

@wxiaoguang commented on GitHub (Jan 9, 2025): > Is pam test not run in CI? Hmm .... it seems that pam test doesn't run in CI because there is no `pam` build tag.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13941