github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Please disable pprof HTTP listener of vendored TiDB #1393

New Issue
Closed
opened 2025-11-02 03:59:12 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 03:59:12 -06:00
Owner
Copy Link

Originally created by @fawick on GitHub (Dec 20, 2017).

/cc @tboerger @lunny

  • Gitea version (or commit ref):
    v1.3.2 (and still in master)
  • Git version:
    git version 2.15.1 (not relevant)
  • Operating system:
    linux/amd64
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
    Not relevant

Description

The vendored github.com/pingcap/tidb package sets up a own HTTP listener at localhost:8888. (see bdf1856011/vendor/github.com/pingcap/tidb/tidb.go (L293-L295)).

Mind you, the variable in the quoted code lines is a different EnablePprof than github.com/go-gitea/gitea/modules/settings.EnablePprof!

I'd suggest to either combine the PPROF instances of TiDB and Gitea, or disable the TiDB one completely by setting github.com/pingcap/tidb.EnablePprof to false.
(EDIT: That's not going work, as the lines in question are run during tidb package initialization, already.)

Screenshots

(no screenshots)

Originally created by @fawick on GitHub (Dec 20, 2017). <!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/NsatcWJ) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> /cc @tboerger @lunny - Gitea version (or commit ref): v1.3.2 (and still in master) - Git version: git version 2.15.1 (not relevant) - Operating system: linux/amd64 - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: Not relevant ## Description The vendored `github.com/pingcap/tidb` package sets up a own HTTP listener at localhost:8888. (see https://github.com/go-gitea/gitea/blob/bdf18560110ac642c196054be38729760a4bbc39/vendor/github.com/pingcap/tidb/tidb.go#L293-L295). Mind you, the variable in the quoted code lines is a different `EnablePprof` than `github.com/go-gitea/gitea/modules/settings.EnablePprof`! ~~I'd suggest to either combine the PPROF instances of TiDB and Gitea, or disable the TiDB one completely by setting `github.com/pingcap/tidb.EnablePprof` to `false`.~~ **(EDIT: That's not going work, as the lines in question are run during `tidb` package initialization, already.)** ## Screenshots (no screenshots) <!-- **If this issue involves the Web Interface, please include a screenshot** -->
GiteaMirror added the type/enhancement label 2025-11-02 03:59:12 -06:00
GiteaMirror commented 2025-11-02 03:59:13 -06:00
Author
Owner
Copy Link

@fawick commented on GitHub (Dec 20, 2017):

For other Gitea users: For the currently vendored version of TiDB, set TIDB_PPROF=0 in your gitea environment to prevent the additional HTTP listener on localhost:8888 from being opened.

@fawick commented on GitHub (Dec 20, 2017): For other Gitea users: For the currently vendored version of TiDB, set `TIDB_PPROF=0` in your gitea environment to prevent the additional HTTP listener on `localhost:8888` from being opened.
GiteaMirror commented 2025-11-02 03:59:13 -06:00
Author
Owner
Copy Link

@tboerger commented on GitHub (Dec 20, 2017):

This should be handled by TiDB, it's pretty crappy that they enable it by default...

@tboerger commented on GitHub (Dec 20, 2017): This should be handled by TiDB, it's pretty crappy that they enable it by default...
GiteaMirror commented 2025-11-02 03:59:14 -06:00
Author
Owner
Copy Link

@fawick commented on GitHub (Dec 20, 2017):

It was handled by TiDB. The version vendored in Gitea does not have those changes, yet.

@fawick commented on GitHub (Dec 20, 2017): It was handled by TiDB. The version vendored in Gitea does not have those changes, yet.
GiteaMirror commented 2025-11-02 03:59:14 -06:00
Author
Owner
Copy Link

@fawick commented on GitHub (Dec 20, 2017):

@tboerger: TiDB handled it in this PR: https://github.com/pingcap/tidb/pull/1541

That PR is older than the commit that added TiDB to Gitea (via go-xorm, I guess.)

@fawick commented on GitHub (Dec 20, 2017): @tboerger: TiDB handled it in this PR: https://github.com/pingcap/tidb/pull/1541 That PR is older than the commit that added TiDB to Gitea (via go-xorm, I guess.)
GiteaMirror commented 2025-11-02 03:59:14 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Dec 20, 2017):

Maybe we need to update tidb vendor

@lunny commented on GitHub (Dec 20, 2017): Maybe we need to update tidb vendor
GiteaMirror commented 2025-11-02 03:59:14 -06:00
Author
Owner
Copy Link

@tboerger commented on GitHub (Dec 20, 2017):

Than some maintainer should update the dependencies.

@tboerger commented on GitHub (Dec 20, 2017): Than some maintainer should update the dependencies.
GiteaMirror commented 2025-11-02 03:59:15 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Sep 10, 2018):

tidb now removed. Closing this issue.

@techknowlogick commented on GitHub (Sep 10, 2018): tidb now removed. Closing this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?